Repository navigation
Comment/implementation disagreement in Thread._bootstrap_inner #71174
Description
| BPO | 26987 |
|---|---|
| Nosy | @zware, @serhiy-storchaka |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2016-05-09.19:50:51.801>
created_at = <Date 2016-05-09.16:26:28.644>
labels = ['type-bug', 'library']
title = 'Comment/implementation disagreement in Thread._bootstrap_inner'
updated_at = <Date 2016-05-09.19:50:51.792>
user = 'https://github.com/zware'bugs.python.org fields:
activity = <Date 2016-05-09.19:50:51.792>
actor = 'python-dev'
assignee = 'none'
closed = True
closed_date = <Date 2016-05-09.19:50:51.801>
closer = 'python-dev'
components = ['Library (Lib)']
creation = <Date 2016-05-09.16:26:28.644>
creator = 'zach.ware'
dependencies = []
files = []
hgrepos = []
issue_num = 26987
keywords = []
message_count = 3.0
messages = ['265208', '265209', '265212']
nosy_count = 3.0
nosy_names = ['python-dev', 'zach.ware', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue26987'
versions = ['Python 3.5', 'Python 3.6']
Activity
zware commentedon May 9, 2016
The comment at Lib/threading.py:925 notes that sys.stderr should be used if possible, but the implementation uses self._stderr in spite of checking _sys.stderr is not None. I believe this was just an oversight in 644b677c2ae5, which added the check and also switched from _sys.stderr.write(...) to print(... file=...).
serhiy-storchaka commentedon May 9, 2016
Good catch! Yes, this is just my mistake. Could you please fix this? I can't commit right now.
python-dev commentedon May 9, 2016
New changeset 8842c02c02a2 by Zachary Ware in branch '3.5':
Issue bpo-26987: Correct implementation to match comment
https://hg.python.org/cpython/rev/8842c02c02a2
New changeset 694dadd9f7bd by Zachary Ware in branch 'default':
Closes bpo-26987: Merge with 3.5
https://hg.python.org/cpython/rev/694dadd9f7bd