Repository navigation
test_socket failures on OS X due to fixed "expected failures" #64673
Description
| BPO | 20474 |
|---|---|
| Nosy | @ncoghlan, @larryhastings, @ned-deily |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/ned-deily'
closed_at = <Date 2014-02-03.22:04:13.143>
created_at = <Date 2014-02-01.10:11:49.560>
labels = ['tests']
title = 'test_socket failures on OS X due to fixed "expected failures"'
updated_at = <Date 2014-02-03.22:04:13.143>
user = 'https://github.com/ned-deily'bugs.python.org fields:
activity = <Date 2014-02-03.22:04:13.143>
actor = 'ned.deily'
assignee = 'ned.deily'
closed = True
closed_date = <Date 2014-02-03.22:04:13.143>
closer = 'ned.deily'
components = ['Tests']
creation = <Date 2014-02-01.10:11:49.560>
creator = 'ned.deily'
dependencies = []
files = ['33843']
hgrepos = []
issue_num = 20474
keywords = ['patch']
message_count = 2.0
messages = ['209882', '210167']
nosy_count = 4.0
nosy_names = ['ncoghlan', 'larry', 'ned.deily', 'python-dev']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue20474'
versions = ['Python 3.3', 'Python 3.4']
Activity
ned-deily commentedon Feb 1, 2014
Three "send timeout" test cases in test_socket were changed by a4e4facad164 for bpo-12958 to be "expected failures" on OS X because of observed failures on the OS X buildbots running OS X 10.6 (Snow Leopard) and earlier.
testInterruptedSendTimeout (test.test_socket.InterruptedSendTimeoutTest) ... unexpected success
testInterruptedSendmsgTimeout (test.test_socket.InterruptedSendTimeoutTest) ... unexpected success
testInterruptedSendtoTimeout (test.test_socket.InterruptedSendTimeoutTest) ... unexpected success
It seems that the platform bugs causing the failures were fixed in OS X 10.7 so that the "expected failures" no longer fail. However, the change in behavior had not been noticed because, until the recent change to unittest in bpo-20165, unittest did not fail when there were unexpected successes. Now it does fail, causing test_socket to fail on OS X 10.7+ for 3.4. On 3.3 the "unexpected success" failures are silently skipped. The attached patch changes the test cases to be skipped for OS X versions prior to 10.7 rather than to always expect failure on OS X.
python-dev commentedon Feb 3, 2014
New changeset 63efacd80f8e by Ned Deily in branch '3.3':
Issue bpo-20474: Fix "unexpected success" test_socket failures on OS X 10.7+.
http://hg.python.org/cpython/rev/63efacd80f8e
New changeset 036671354dc0 by Ned Deily in branch 'default':
Issue bpo-20474: Fix "unexpected success" test_socket failures on OS X 10.7+.
http://hg.python.org/cpython/rev/036671354dc0