Repository navigation
zipfile's readline() drops data in universal newline mode #64247
Description
| BPO | 20048 |
|---|---|
| Nosy | @abalkin, @serhiy-storchaka |
| Dependencies | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2013-12-21.21:55:42.140>
created_at = <Date 2013-12-21.20:58:59.324>
labels = ['type-bug', 'library']
title = "zipfile's readline() drops data in universal newline mode"
updated_at = <Date 2013-12-21.21:55:42.139>
user = 'https://github.com/abalkin'bugs.python.org fields:
activity = <Date 2013-12-21.21:55:42.139>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2013-12-21.21:55:42.140>
closer = 'serhiy.storchaka'
components = ['Library (Lib)']
creation = <Date 2013-12-21.20:58:59.324>
creator = 'belopolsky'
dependencies = ['14371']
files = ['33253']
hgrepos = []
issue_num = 20048
keywords = ['patch']
message_count = 5.0
messages = ['206779', '206784', '206785', '206788', '206789']
nosy_count = 4.0
nosy_names = ['belopolsky', 'alanmcintyre', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue20048'
versions = ['Python 2.7']
Activity
abalkin commentedon Dec 21, 2013
This problem happens when I unpack a file from a 200+ MB zip archive as follows:
I cannot reduce it to a test case suitable for posting here, but the culprit is the following code in zipfile.py:
See http://hg.python.org/cpython/file/81f8375e60ce/Lib/zipfile.py#l605
The problem occurs when peek() is called on the boundary of the uncompress buffer and read() goes through more than one readbuffer. The result is that self._offset is smaller than len(chunk) leading to a non-sensical negative self._offset upon return from peek().
This problem does not seem to appear in 3.x since 028e8e0b03e8.
serhiy-storchaka commentedon Dec 21, 2013
Does this patch fix a bug?
abalkin commentedon Dec 21, 2013
It does!
python-dev commentedon Dec 21, 2013
New changeset 8b097d07488d by Serhiy Storchaka in branch '2.7':
Issue bpo-20048: Fixed ZipExtFile.peek() when it is called on the boundary of
http://hg.python.org/cpython/rev/8b097d07488d
serhiy-storchaka commentedon Dec 21, 2013
Than you for your report and irrefragable analysis.