Repository navigation
test_venv: test_with_pip() failed on "AMD64 Fedora without threads 3.x" buildbot: urllib3 dependency requires the threading module #63965
Description
| BPO | 19766 |
|---|---|
| Nosy | @vsajip, @ncoghlan, @vstinner, @tiran, @dstufft |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/dstufft'
closed_at = <Date 2013-12-21.15:21:19.460>
created_at = <Date 2013-11-25.09:41:00.194>
labels = ['type-bug', 'tests']
title = 'test_venv: test_with_pip() failed on "AMD64 Fedora without threads 3.x" buildbot: urllib3 dependency requires the threading module'
updated_at = <Date 2013-12-21.15:21:29.702>
user = 'https://github.com/vstinner'bugs.python.org fields:
activity = <Date 2013-12-21.15:21:29.702>
actor = 'ncoghlan'
assignee = 'dstufft'
closed = True
closed_date = <Date 2013-12-21.15:21:19.460>
closer = 'ncoghlan'
components = ['Tests']
creation = <Date 2013-11-25.09:41:00.194>
creator = 'vstinner'
dependencies = []
files = ['32857']
hgrepos = []
issue_num = 19766
keywords = ['patch', 'buildbot']
message_count = 15.0
messages = ['204316', '204413', '204475', '204495', '205111', '205506', '205512', '205535', '205542', '205557', '205590', '205813', '206225', '206227', '206753']
nosy_count = 5.0
nosy_names = ['vinay.sajip', 'ncoghlan', 'vstinner', 'christian.heimes', 'dstufft']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue19766'
versions = ['Python 3.4']
Activity
vstinner commentedon Nov 25, 2013
The line "from . import exceptions" of urllib3 failed:
https://github.com/shazow/urllib3/blob/master/urllib3/__init__.py#L22
It is strange because urllib3/exceptions.py is part of the urllib3 module.
http://buildbot.python.org/all/builders/AMD64%20Fedora%20without%20threads%203.x/builds/5674/steps/test/logs/stdio
======================================================================
FAIL: test_with_pip (test.test_venv.EnsurePipTest)
----------------------------------------------------------------------
ncoghlan commentedon Nov 25, 2013
Potentially another platform compatibility issue for pip's dependencies.
vstinner commentedon Nov 26, 2013
In fact, it's an issue in the urllib3 library which require threads.
Here is a patch for urllib3.
I reported the issue upstream:
urllib3/urllib3#289
vstinner commentedon Nov 26, 2013
Cool, my patch was already applied upstream:
urllib3/urllib3@929f158
@nick: can you try to package a new wheel package for pip?
[-]test_venv: test_with_pip() failed on "AMD64 Fedora without threads 3.x" buildbot[/-][+]test_venv: test_with_pip() failed on "AMD64 Fedora without threads 3.x" buildbot: urllib3 dependency requires the threading module[/+]dstufft commentedon Dec 3, 2013
The urllib3 in requests VCS was updated, I just need to bother Kenneth to make a new release of requests or update pip to an unreleased requests.
ncoghlan commentedon Dec 8, 2013
bpo-19924 suggests we may need a new distlib as well
dstufft commentedon Dec 8, 2013
Requests was released and pip updated it, I can release a new pip but it appears that perhaps distlib needs fixed before the without threads case is taken care of?
vsajip commentedon Dec 8, 2013
I will look at doing a distlib update shortly - but there's another issue (bpo-19913) that might also require an update - it' not clear yet.
vsajip commentedon Dec 8, 2013
I've updated distlib to use dummy_threading where threading isn't available - see
https://bitbucket.org/pypa/distlib/commits/029fee573900765729402203e39b2171d7ae0784
Can someone please test with this version vendored into pip to check that the failures no longer occur in a no-thread environment, before I do a distlib release?
tiran commentedon Dec 8, 2013
Vinay, thanks for your fast response! :) bpo-19913 should be resolved, too. A couple of months ago several people complained about a new file that looked like a ZIP bomb. This virus warnings looks even more severe although it's probably a false positive. Could you try a new set of binaries without UPX? https://www.virustotal.com/ lets you scan the files with more than 40 programs at once and for free.
vsajip commentedon Dec 8, 2013
This commit in distlib uses uncompressed launcher executables which pass the virustotal.com checks:
https://bitbucket.org/pypa/distlib/commits/e23c9e4fd3125fa88063de4dec80367b1ac82aff
dstufft commentedon Dec 10, 2013
Vinay, I've verified that the current default branch of distlib works without threading when vendored in pip and these tests pass.
vsajip commentedon Dec 15, 2013
I've released distlib 0.1.5 on PyPI. This release uses dummy_threading when threading isn't available.
ncoghlan commentedon Dec 15, 2013
Not quite fixed yet - Donald, I think all the vendored dependencies have been updated now, would it be possible to spin and incorporate a pip 1.5rc2 somewhat soonish so we know what's still left to be addressed on the ensurepip side?
ncoghlan commentedon Dec 21, 2013
Donald updated CPython to pip 1.5rc2, so test_venv is now passing without threading support:
http://buildbot.python.org/all/builders/AMD64%20Fedora%20without%20threads%203.x/builds/5874/steps/test/logs/stdio