Skip to content

test_asyncio: test__run_once timings should be relaxed #63778

Closed

Description

@vstinner
BPO 19579
Nosy @gvanrossum, @pitrou, @vstinner, @ezio-melotti

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-12-13.00:35:00.155>
created_at = <Date 2013-11-14.01:00:00.908>
labels = ['tests']
title = 'test_asyncio: test__run_once timings should be relaxed'
updated_at = <Date 2013-12-13.00:35:00.147>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2013-12-13.00:35:00.147>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2013-12-13.00:35:00.155>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2013-11-14.01:00:00.908>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 19579
keywords = []
message_count = 5.0
messages = ['202813', '202818', '204054', '204058', '205998']
nosy_count = 5.0
nosy_names = ['gvanrossum', 'pitrou', 'vstinner', 'ezio.melotti', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue19579'
versions = ['Python 3.4']

Activity

  1. vstinner commented on Nov 14, 2013

    @vstinner
    MemberAuthor

    On Windows, the monotonic timer has a resolution of 15 ms in the worst case. The timing should accept a greater error.

    http://buildbot.python.org/all/builders/x86%20XP-4%203.x/builds/9547/steps/test/logs/stdio

    ======================================================================
    FAIL: test__run_once (test.test_asyncio.test_base_events.BaseEventLoopTests)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows\build\lib\test\test_asyncio\test_base_events.py", line 184, in test__run_once
        self.assertTrue(9.99 < t < 10.1, t)
    AssertionError: False is not true : 9.989999999990687
  2. python-dev commented on Nov 14, 2013

    python-devmannequin
    Mannequin

    New changeset f91550e7e2b7 by Guido van Rossum in branch 'default':
    asyncio: Relax timing requirement. Fixes bpo-19579.
    http://hg.python.org/cpython/rev/f91550e7e2b7

  3. vstinner commented on Nov 23, 2013

    @vstinner
    MemberAuthor

    Oh, the problem is now in the opposite direction... Windows clocks don't look to be reliable or the buildbot is very busy :-/

    http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/7586/steps/test/logs/stdio

    ======================================================================
    FAIL: test__run_once (test.test_asyncio.test_base_events.BaseEventLoopTests)
    ----------------------------------------------------------------------

    Traceback (most recent call last):
      File "D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_asyncio\test_base_events.py", line 184, in test__run_once
        self.assertTrue(9.9 < t < 10.1, t)
    AssertionError: False is not true : 9.71900000050664
  4. python-dev commented on Nov 23, 2013

    python-devmannequin
    Mannequin

    New changeset 085091cb6e4c by Guido van Rossum in branch 'default':
    Relax timing even more, hopefully again fixes bpo-19579.
    http://hg.python.org/cpython/rev/085091cb6e4c

  5. vstinner commented on Dec 13, 2013

    @vstinner
    MemberAuthor

    I didn't see the failure recently, thanks.

  6. transferred this issue fromon Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dir

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions