Repository navigation
Don't check for PYTHONCASEOK if interpreter started with -E #61030
Description
| BPO | 16826 |
|---|---|
| Nosy | @brettcannon, @ncoghlan, @vstinner, @merwok, @meadori, @ericsnowcurrently |
| Superseder | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/meadori'
closed_at = <Date 2020-05-15.00:47:33.889>
created_at = <Date 2012-12-31.14:34:51.477>
labels = ['interpreter-core', 'type-bug', '3.9']
title = "Don't check for PYTHONCASEOK if interpreter started with -E"
updated_at = <Date 2020-05-15.00:47:33.888>
user = 'https://github.com/brettcannon'bugs.python.org fields:
activity = <Date 2020-05-15.00:47:33.888>
actor = 'vstinner'
assignee = 'meador.inge'
closed = True
closed_date = <Date 2020-05-15.00:47:33.889>
closer = 'vstinner'
components = ['Interpreter Core']
creation = <Date 2012-12-31.14:34:51.477>
creator = 'brett.cannon'
dependencies = []
files = ['28517', '29858']
hgrepos = []
issue_num = 16826
keywords = ['patch', '3.2regression']
message_count = 13.0
messages = ['178679', '178723', '179483', '180001', '186964', '196876', '196880', '196882', '196928', '275077', '275114', '360917', '368886']
nosy_count = 7.0
nosy_names = ['brett.cannon', 'ncoghlan', 'vstinner', 'eric.araujo', 'meador.inge', 'python-dev', 'eric.snow']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '38691'
type = 'behavior'
url = 'https://bugs.python.org/issue16826'
versions = ['Python 3.9']
Activity
brettcannon commentedon Dec 31, 2012
Importlib, when checking for PYTHONCASEOK, does not respect -E as it did in Python 3.2 and earlier (http://hg.python.org/cpython/file/0786dfc3b2b4/Python/import.c#l1933).
meadori commentedon Jan 1, 2013
Is the attached OK?
merwok commentedon Jan 9, 2013
Code patch looks good, but for tests, I prefer to run subprocesses with the options and output I want, instead of changing the expected results depending on the python-running-tests’ options (and thus, having two tests into one, but always running only one).
meadori commentedon Jan 15, 2013
I agree that it is better to cover both cases in one test irrespective of the interpreter command line options. I will take a look at creating a subprocess. Thanks for the review.
meadori commentedon Apr 15, 2013
Here is a version which implements the subprocess method for testing
suggested by Éric.
python-dev commentedon Sep 3, 2013
New changeset 934e650abc4d by Meador Inge in branch '3.3':
Issue bpo-16826: Don't check for PYTHONCASEOK when using -E.
http://hg.python.org/cpython/rev/934e650abc4d
New changeset ba850a78cbbc by Meador Inge in branch 'default':
Issue bpo-16826: Don't check for PYTHONCASEOK when using -E.
http://hg.python.org/cpython/rev/ba850a78cbbc
meadori commentedon Sep 3, 2013
My last commit caused some buildbot failures (http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.3/builds/1069). I am investigating.
python-dev commentedon Sep 4, 2013
New changeset 7801ef4a4ce3 by Meador Inge in branch '3.3':
Issue bpo-16826: Revert fix while Windows issues are being worked out.
http://hg.python.org/cpython/rev/7801ef4a4ce3
New changeset a1282b67b4cf by Meador Inge in branch 'default':
Issue bpo-16826: Revert fix while Windows issues are being worked out.
http://hg.python.org/cpython/rev/a1282b67b4cf
meadori commentedon Sep 4, 2013
Reopening to rework test cases.
ericsnowcurrently commentedon Sep 8, 2016
What ended up happening with this?
meadori commentedon Sep 8, 2016
Nothing. I didn't have a Windows box handy to investigate at the time. I do now and can look into this in the next day or so.
brettcannon commentedon Jan 29, 2020
This is still occurring. Probably need to add
and sys.ignore_environmenttocpython/Lib/importlib/_bootstrap_external.py
Line 38 in 0cd5bff
vstinner commentedon May 15, 2020
Issue fixed in bpo-38691:
commit fc72ab6
Author: idomic <[email protected]>
Date: Mon Mar 9 07:57:53 2020 -0400