Skip to content

python shouldn't need username in passwd database #58446

Closed
Closed
python shouldn't need username in passwd database#58446
Labels
easystdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

Description

@arekm
arekm
mannequin
opened on Mar 9, 2012
BPO 14238
Nosy @loewis, @birkenfeld, @arekm, @vstinner, @merwok
Superseder
  • bpo-10496: Python startup should not require passwd entry
    		•
    Files
  • issue14238.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2012-03-13.00:04:10.160>
created_at = <Date 2012-03-09.09:21:59.509>
labels = ['easy', 'type-bug', 'library']
title = "python shouldn't need username in passwd database"
updated_at = <Date 2012-03-13.00:07:40.829>
user = 'https://github.com/arekm'

    bugs.python.org fields:

    activity = <Date 2012-03-13.00:07:40.829>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2012-03-13.00:04:10.160>
closer = 'eric.araujo'
components = ['Library (Lib)']
creation = <Date 2012-03-09.09:21:59.509>
creator = 'arekm'
dependencies = []
files = ['24800']
hgrepos = []
issue_num = 14238
keywords = ['patch', 'easy', 'buildbot']
message_count = 12.0
messages = ['155215', '155216', '155218', '155279', '155465', '155486', '155488', '155493', '155494', '155499', '155529', '155531']
nosy_count = 7.0
nosy_names = ['loewis', 'georg.brandl', 'arekm', 'vstinner', 'nadeem.vawda', 'eric.araujo', 'aikinci']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = 'resolved'
status = 'closed'
superseder = '10496'
type = 'behavior'
url = 'https://bugs.python.org/issue14238'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

    Activity

    1. arekm commented on Mar 9, 2012

      @arekm
      arekmmannequin
      on Mar 9, 2012
      MannequinAuthor

      I'm trying to run python from UID which doesn't have entry in passwd database. This fails with:

       Traceback (most recent call last):
File "/usr/share/python2.7/site.py", line 567, in <module>
File "/usr/share/python2.7/site.py", line 549, in main
File "/usr/share/python2.7/site.py", line 278, in addusersitepackages
File "/usr/share/python2.7/site.py", line 253, in getusersitepackages
File "/usr/share/python2.7/site.py", line 243, in getuserbase
File "/usr/share/python2.7/sysconfig.py", line 522, in get_config_var
File "/usr/share/python2.7/sysconfig.py", line 426, in get_config_vars
File "/usr/share/python2.7/sysconfig.py", line 184, in _getuserbase
File "/usr/share/python2.7/sysconfig.py", line 171, in joinuser
File "/usr/share/python2.7/posixpath.py", line 260, in expanduser
KeyError: 'getpwuid(): uid not found: 51'
    2. arekm
      added
      interpreter-core(Objects, Python, Grammar, and Parser dirs)
      on Mar 9, 2012

    3. nadeemvawda commented on Mar 9, 2012

      @nadeemvawda
      nadeemvawdamannequin
      on Mar 9, 2012
      Mannequin

      This looks similar to a sporadic failure on the debian bigmem buildbot:

      http://www.python.org/dev/buildbot/all/builders/AMD64%20debian%20bigmem%203.x/builds/168/steps/test/logs/stdio

      ERROR: test_expanduser (test.test_posixpath.PosixPathTest)
\----------------------------------------------------------------------

          Traceback (most recent call last):
      File "/var/tmpfs/martin.vonloewis/3.x.loewis-parallel2/build/Lib/test/test_posixpath.py", line 305, in test_expanduser
        home = pwd.getpwuid(os.getuid()).pw_dir
    KeyError: 'getpwuid(): uid not found: 5025'
    4. nadeemvawda
      added
      stdlibStandard Library Python modules in the Lib/ directory
      type-bugAn unexpected behavior, bug, or error
      and removed
      interpreter-core(Objects, Python, Grammar, and Parser dirs)
      on Mar 9, 2012

    5. birkenfeld commented on Mar 9, 2012

      @birkenfeld
      birkenfeld
      on Mar 9, 2012
      Member

      I agree -- there should be a guard here that just doesn't add user site directories if the lookup fails.

    6. pitrou
      added
      easy
      on Mar 9, 2012

    7. merwok commented on Mar 10, 2012

      @merwok
      merwok
      on Mar 10, 2012
      Member

      there should be a guard here that just doesn't add user site directories if the lookup fails.
      Agreed too. site is easy to fix (I can do it or review a patch), but we also need to fix sysconfig; I think the right thing to do would be not to have a config var named 'userbase' when run from a UID without passwd entry. This implies that the functions listed under http://docs.python.org/library/sysconfig#installation-paths would also need to omit *user schemes.

    8. aikinci commented on Mar 12, 2012

      @aikinci
      aikincimannequin
      on Mar 12, 2012
      Mannequin

      I have started to work on this.

    9. aikinci commented on Mar 12, 2012

      @aikinci
      aikincimannequin
      on Mar 12, 2012
      Mannequin

      This patch fixes the issue but needs review. It is my first patch ever so be nice :)

    10. merwok commented on Mar 12, 2012

      @merwok
      merwok
      on Mar 12, 2012
      Member

      Thanks you for your contribution! I hope you’ll find fun bugs to make patches for.

      Your patch looks too simplistic; in the discussion, we agreed that if the lookup fails, the site module should not add user site directories (see http://docs.python.org/library/site#site.USER_SITE or PEP-370), and your patch does not seem to do that.

      Moreover, this bug has repercussions on the sysconfig module (see my previous message), which needs edits too.

      BTW, I don’t know how we can test a patch for this bug; arekm, how do you run Python from a UID without passwd entry?

    11. arekm commented on Mar 12, 2012

      @arekm
      arekmmannequin
      on Mar 12, 2012
      MannequinAuthor
      $  LC_ALL=C sudo -u '#9999' -g '#9999' /bin/sh -c 'unset HOME ; python -c ""'
Traceback (most recent call last):
  File "/usr/share/python2.7/site.py", line 567, in <module>
    main()
  File "/usr/share/python2.7/site.py", line 549, in main
    known_paths = addusersitepackages(known_paths)
  File "/usr/share/python2.7/site.py", line 278, in addusersitepackages
    user_site = getusersitepackages()
  File "/usr/share/python2.7/site.py", line 253, in getusersitepackages
    user_base = getuserbase() # this will also set USER_BASE
  File "/usr/share/python2.7/site.py", line 243, in getuserbase
    USER_BASE = get_config_var('userbase')
  File "/usr/share/python2.7/sysconfig.py", line 522, in get_config_var
    return get_config_vars().get(name)
  File "/usr/share/python2.7/sysconfig.py", line 426, in get_config_vars
    _CONFIG_VARS['userbase'] = _getuserbase()
  File "/usr/share/python2.7/sysconfig.py", line 184, in _getuserbase
    return env_base if env_base else joinuser("~", ".local")
  File "/usr/share/python2.7/sysconfig.py", line 171, in joinuser
    return os.path.expanduser(os.path.join(*args))
  File "/usr/share/python2.7/posixpath.py", line 260, in expanduser
    userhome = pwd.getpwuid(os.getuid()).pw_dir
KeyError: 'getpwuid(): uid not found: 9999'

    12. vstinner commented on Mar 12, 2012

      @vstinner
      vstinner
      on Mar 12, 2012
      Member

      See also the issue bpo-10496.

    13. aikinci commented on Mar 12, 2012

      @aikinci
      aikincimannequin
      on Mar 12, 2012
      Mannequin

      I would suggest that this issue is the same as http://bugs.python.org/issue10496 like Victor pointed out and would say close it because it is a duplicate.

    14. merwok commented on Mar 13, 2012

      @merwok
      merwok
      on Mar 13, 2012
      Member

      Indeed.

    15. merwok
      closed this as completedon Mar 13, 2012

    16. vstinner commented on Mar 13, 2012

      @vstinner
      vstinner
      on Mar 13, 2012
      Member

      This patch fixes the issue but needs review.
      It is my first patch ever so be nice :)

      Python should not decide what is the default home directory. The issue is in the site module: I proposed nonexistent_user.patch in the issue bpo-10496 to fix the issue in the site module instead.

    17. ezio-melotti
      transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      easystdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions