Repository navigation
Use universal newlines mode for setup.cfg #57109
Description
| BPO | 12900 |
|---|---|
| Nosy | @tarekziade, @merwok |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/tarekziade'
closed_at = <Date 2014-03-12.10:39:57.333>
created_at = <Date 2011-09-05.16:05:18.599>
labels = ['easy', 'type-bug']
title = 'Use universal newlines mode for setup.cfg'
updated_at = <Date 2014-03-12.10:39:57.332>
user = 'https://github.com/merwok'bugs.python.org fields:
activity = <Date 2014-03-12.10:39:57.332>
actor = 'eric.araujo'
assignee = 'tarek'
closed = True
closed_date = <Date 2014-03-12.10:39:57.333>
closer = 'eric.araujo'
components = ['Distutils2']
creation = <Date 2011-09-05.16:05:18.599>
creator = 'eric.araujo'
dependencies = []
files = []
hgrepos = []
issue_num = 12900
keywords = ['easy']
message_count = 1.0
messages = ['143539']
nosy_count = 3.0
nosy_names = ['tarek', 'eric.araujo', 'alexis']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue12900'
versions = ['3rd party', 'Python 3.3']
Activity
merwok commentedon Sep 5, 2011
We need tests to make sure that setup.cfg files using CRLF or CR as newline character work. We could require that people use LF in the spec, but I don’t think it’s worth it, as it’s simple enough to support all newlines whereas Windows users can’t always use LF easily.
For packaging in 3.3, opening the file in text mode gives us universal newlines for free, so the code is good but we need tests. For distutils2 in 2.x, we need to pass 'rU' as open flags.