Tools/Scripts/crlf.py needs updating for python 3+ #56241

Activity

1. stephenferg commented on May 8, 2011

   

   stephenfergmannequin

   on May 8, 2011

   MannequinAuthor

   More actions

   I think this is a consequence of the new Unicode support in Python 3+

   Here is code copied from C:\Python32\Tools\Scripts\crlf.py (on windows)
   ==================================================================

       for filename in os.listdir("."):
           if os.path.isdir(filename):
               print(filename, "Directory!")
               continue
           data = open(filename, "rb").read()
           if '\0' in data:
               print(filename, "Binary!")
               continue
           newdata = data.replace("\r\n", "\n")
           if newdata != data:
               print(filename)

   ===================================================================

   When run, it produces this (run under the PyCharm debugger)

   ===================================================================

   C:\Python32\python.exe C:/pydev/zob/zobtest.py
   Traceback (most recent call last):
     File "C:/pydev/zob/zobtest.py", line 134, in <module>
       x() 
     File "C:/pydev/zob/zobtest.py", line 126, in x
       if '\0' in data:
   TypeError: Type str doesn't support the buffer API

   Process finished with exit code 1
   ===================================================================

   Removing the test for "\0" produces this:
   ===================================================================

   C:\Python32\python.exe C:/pydev/zob/zobtest.py
   Traceback (most recent call last):
     File "C:/pydev/zob/zobtest.py", line 131, in <module>
       x()  
     File "C:/pydev/zob/zobtest.py", line 126, in x
       newdata = data.replace("\r\n", "\n")
   TypeError: expected an object with the buffer interface

   Process finished with exit code 1
   ===================================================================
2. stephenferg

   added

   type-crashA hard crash of the interpreter, possibly with a core dumpA hard crash of the interpreter, possibly with a core dump

   on May 8, 2011
3. python-dev commented on May 8, 2011

   

   python-devmannequin

   on May 8, 2011

   Mannequin

   More actions

   New changeset f94d74c85dcb by Victor Stinner in branch 'default':
   Close bpo-12032: Fix scripts/crlf.py for Python 3
   http://hg.python.org/cpython/rev/f94d74c85dcb
4. python-dev

   closed this as completedon May 8, 2011
5. bitdancer

   changed the title [-]Tools/Scripts/crlv.py needs updating for python 3+[/-] [+]Tools/Scripts/crlf.py needs updating for python 3+[/+] on Aug 5, 2011
6. bitdancer

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   and removed

   type-crashA hard crash of the interpreter, possibly with a core dumpA hard crash of the interpreter, possibly with a core dump

   on Aug 5, 2011
7. merwok commented on Aug 8, 2011

   

   merwok

   on Aug 8, 2011

   Member

   More actions

   This needs porting to 3.2.
8. merwok

   reopened this on Aug 8, 2011
9. python-dev commented on Aug 12, 2011

   

   python-devmannequin

   on Aug 12, 2011

   Mannequin

   More actions

   New changeset 47ffb957921d by Éric Araujo in branch '3.2':
   Update crlf and lfcr scripts for 3.x bytes semantics (bpo-12032).
   http://hg.python.org/cpython/rev/47ffb957921d
10. merwok

    closed this as completedon Aug 12, 2011
11. merwok

    self-assigned this

    on Aug 12, 2011
12. ezio-melotti

    transferred this issue fromon Apr 10, 2022