Repository navigation
Modular interpolation in configparser #54708
Description
| BPO | 10499 |
|---|---|
| Nosy | @freddrake, @birkenfeld, @rhettinger, @merwok, @ambv |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/ambv'
closed_at = <Date 2010-12-03.16:29:45.449>
created_at = <Date 2010-11-22.03:16:24.286>
labels = ['type-feature', 'library']
title = 'Modular interpolation in configparser'
updated_at = <Date 2010-12-03.16:29:45.447>
user = 'https://github.com/ambv'bugs.python.org fields:
activity = <Date 2010-12-03.16:29:45.447>
actor = 'lukasz.langa'
assignee = 'lukasz.langa'
closed = True
closed_date = <Date 2010-12-03.16:29:45.449>
closer = 'lukasz.langa'
components = ['Library (Lib)']
creation = <Date 2010-11-22.03:16:24.286>
creator = 'lukasz.langa'
dependencies = []
files = ['19767']
hgrepos = []
issue_num = 10499
keywords = ['patch', 'needs review']
message_count = 4.0
messages = ['122078', '122537', '122744', '123258']
nosy_count = 6.0
nosy_names = ['fdrake', 'georg.brandl', 'rhettinger', 'eric.araujo', 'lukasz.langa', 'asolovyov']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue10499'
versions = ['Python 3.2']
Activity
ambv commentedon Nov 22, 2010
SUMMARY
=======
This is a refactoring of configparser raised from discussions on bpo-6517 and bpo-9876. It solves both issues and makes the code quite elegant. Best part is, it's fully backwards compatible [1].
In the patch I basically did:
a) move the interpolation functionality out of the parsers
b) deprecate RCP and CP in favor of SCP
c) refactor the resulting code to get rid of duplicates
This means that actually despite the generalization and introduction of deprecation warnings, configparser lost 22 lines in the process. The implementation is complete and unit tested.
WHAT'S LEFT TO DO
=================
Obviously the new
interpolationinit argument needs docs. This includes the docstrings on *Interpolation classes that describe how the algorithms work.ExtendedInterpolationclass implementing the buildout syntax, that would satisfy the request from bpo-9876.Once we have more interpolation implementations new test cases will be added to test_cfgparser.py.
Will do all three when I have any opinions on the current direction.
REVIEW HINTS
============
I need some thumbs up or advice on the design decisions made.
interpolationnow takes a class, init instantiates an object on its own. Do tell if taking an object upfront would be a better approach.*Interpolation classes have methods which take the parser as an argument. Do tell if making it an object attribute would be a better approach.
All other points of interest during a review naturally apply here too.
[1] Assuming _names are private and can be moved around when needed.
ambv commentedon Nov 27, 2010
Patch reposted here for review: http://codereview.appspot.com/3309043/
freddrake commentedon Nov 28, 2010
Review posted.
ambv commentedon Dec 3, 2010
Committed in rev 86976.