Repository navigation
ctypes: remove implicit conversion between unicode and bytes #53212
Description
| BPO | 8966 |
|---|---|
| Nosy | @theller, @vstinner, @florentx |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/theller'
closed_at = <Date 2010-07-28.00:22:40.553>
created_at = <Date 2010-06-10.23:03:25.738>
labels = ['ctypes', 'expert-unicode']
title = 'ctypes: remove implicit conversion between unicode and bytes'
updated_at = <Date 2010-07-28.00:22:40.475>
user = 'https://github.com/vstinner'bugs.python.org fields:
activity = <Date 2010-07-28.00:22:40.475>
actor = 'vstinner'
assignee = 'theller'
closed = True
closed_date = <Date 2010-07-28.00:22:40.553>
closer = 'vstinner'
components = ['Unicode', 'ctypes']
creation = <Date 2010-06-10.23:03:25.738>
creator = 'vstinner'
dependencies = []
files = ['17611', '17612', '17634']
hgrepos = []
issue_num = 8966
keywords = ['patch']
message_count = 4.0
messages = ['107499', '107590', '107591', '111750']
nosy_count = 3.0
nosy_names = ['theller', 'vstinner', 'flox']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue8966'
versions = ['Python 3.2']
Activity
vstinner commentedon Jun 10, 2010
ctypes doesn't have strict separation between bytes and characters, whereas Python3 splitted str/unicode of Python2 into bytes/str which a strict separation. The result is that sometimes it works (no error), sometimes it fails (the first time that the user inserts a non-ASCII character).
I wrote 3 patches:
ctypes_s_set.patch is trivial and fixes a real bug. ctypes_conversion.patch does basically remove code. ctypes_tests.patch is the biggest part because the test suite is mostly based on the implicit conversion.
Except the parts removing the calls to ctypes.set_conversion_mode() and the tests testing the implicit conversion, ctypes_tests.patch can be commited alone because it improves the test suite (use the right types).
vstinner commentedon Jun 11, 2010
I commited ctypes_s_set.patch in Python 3.2 (r81911) because it does fix a real bug.
vstinner commentedon Jun 11, 2010
Update ctypes_tests.patch against last changes: ctypes_tests-2.patch.
vstinner commentedon Jul 28, 2010
I commited both patches to 3.2, but I splitted them in a different way:
So it's easier to review the commits and revert the second commit.