Repository navigation
HTTP/1.1 with keep-alive support for xmlrpclib.ServerProxy #50349
Description
| BPO | 6099 |
|---|---|
| Nosy | @loewis, @kristjanvalur |
| Superseder | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2009-06-20.16:28:08.286>
created_at = <Date 2009-05-24.20:52:10.947>
labels = ['library', 'performance']
title = 'HTTP/1.1 with keep-alive support for xmlrpclib.ServerProxy'
updated_at = <Date 2009-06-20.16:28:08.273>
user = 'https://github.com/kristjanvalur'bugs.python.org fields:
activity = <Date 2009-06-20.16:28:08.273>
actor = 'loewis'
assignee = 'none'
closed = True
closed_date = <Date 2009-06-20.16:28:08.286>
closer = 'loewis'
components = ['Library (Lib)']
creation = <Date 2009-05-24.20:52:10.947>
creator = 'kristjan.jonsson'
dependencies = []
files = ['14059', '14067', '14225']
hgrepos = []
issue_num = 6099
keywords = ['patch', 'needs review']
message_count = 4.0
messages = ['88283', '88316', '89078', '89542']
nosy_count = 2.0
nosy_names = ['loewis', 'kristjan.jonsson']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = None
status = 'closed'
superseder = '6267'
type = 'performance'
url = 'https://bugs.python.org/issue6099'
versions = ['Python 3.0', 'Python 2.7']
Activity
kristjanvalur commentedon May 24, 2009
The Transport class in xmlrpclib.py was using the old httplib.HTTP
class.
This patch brings xmlrpclib up to date to use the HTTPConnection and
HTTPSConnection classes. This allows xlmrpclib.ServerProxy to use
HTTP/1.1 with keep-alive on
servers that support it.
Note that this patch benefits from recent optimizations of
HTTPConnection reducing the Nagle problem.
This is a separate patch from http://bugs.python.org/issue1767370 and in
my opinion much simpler.
See also
http://bugs.python.org/issue2076
Patch uploaded as http://codereview.appspot.com/63144
kristjanvalur commentedon May 25, 2009
I attach another patch, keepalive.patch, which includes the fixes from http://bugs.python.org/issue6096 and including a test for the keepalive
mecahinsm in the test suite.
Updated http://codereview.appspot.com/63144
kristjanvalur commentedon Jun 8, 2009
It turns out we need to deal with exceptions and clear the cached
HTTPConnection if they happen.
Also, we just deal with a ECONNRESET which can happen if there is a long
delay between requests, and retry the request once in that case. New
patch uploaded.
loewis commentedon Jun 20, 2009
Superseded by bpo-6267.