Repository navigation
SimpleXMLRPCServer not suitable for HTTP/1.1 keep-alive #50346
Description
| BPO | 6096 |
|---|---|
| Nosy | @loewis, @kristjanvalur |
| Superseder | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2009-06-20.16:28:38.450>
created_at = <Date 2009-05-24.17:06:48.705>
labels = ['easy', 'type-bug', 'library']
title = 'SimpleXMLRPCServer not suitable for HTTP/1.1 keep-alive'
updated_at = <Date 2009-06-20.16:28:38.448>
user = 'https://github.com/kristjanvalur'bugs.python.org fields:
activity = <Date 2009-06-20.16:28:38.448>
actor = 'loewis'
assignee = 'none'
closed = True
closed_date = <Date 2009-06-20.16:28:38.450>
closer = 'loewis'
components = ['Library (Lib)']
creation = <Date 2009-05-24.17:06:48.705>
creator = 'kristjan.jonsson'
dependencies = []
files = ['14053', '14244']
hgrepos = []
issue_num = 6096
keywords = ['patch', 'easy', 'needs review']
message_count = 3.0
messages = ['88269', '89147', '89543']
nosy_count = 2.0
nosy_names = ['loewis', 'kristjan.jonsson']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = None
status = 'closed'
superseder = '6267'
type = 'behavior'
url = 'https://bugs.python.org/issue6096'
versions = ['Python 2.6', 'Python 2.5', 'Python 2.7']
Activity
kristjanvalur commentedon May 24, 2009
The SimpleXMRRPCServer class calls connection.shutdown(1) when done with
each request, thus making it unsuitable for a RequestHandler that supports
HTTP/1.1 with keep-alive. This patch removes those extra shutdown calls.
Patch also uploaded as
http://codereview.appspot.com/63143
kristjanvalur commentedon Jun 9, 2009
Here is a better patch.
Remove the individual flush() operations from the implementation classes,
rather do it in the BaseHTTPRequestHandler(). This allows any request
handler to be write buffered.
loewis commentedon Jun 20, 2009
Superseded by bpo-6267.