Repository navigation
turtle.py update: 1.0 --> 1.1 #50173
Description
| BPO | 5923 |
|---|---|
| Nosy | @loewis, @birkenfeld, @rhettinger, @benjaminp, @bitdancer |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2009-05-05.08:15:40.017>
created_at = <Date 2009-05-04.14:56:37.319>
labels = ['type-feature', 'library']
title = 'turtle.py update: 1.0 --> 1.1'
updated_at = <Date 2009-05-05.08:15:40.006>
user = 'https://bugs.python.org/gregorlingl'bugs.python.org fields:
activity = <Date 2009-05-05.08:15:40.006>
actor = 'georg.brandl'
assignee = 'none'
closed = True
closed_date = <Date 2009-05-05.08:15:40.017>
closer = 'georg.brandl'
components = ['Library (Lib)']
creation = <Date 2009-05-04.14:56:37.319>
creator = 'gregorlingl'
dependencies = []
files = ['13870', '13871', '13879', '13880', '13885', '13886', '13889']
hgrepos = []
issue_num = 5923
keywords = ['patch']
message_count = 11.0
messages = ['87132', '87133', '87166', '87179', '87184', '87185', '87186', '87194', '87195', '87201', '87221']
nosy_count = 6.0
nosy_names = ['loewis', 'georg.brandl', 'rhettinger', 'gregorlingl', 'benjamin.peterson', 'r.david.murray']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue5923'
versions = ['Python 3.1']
Activity
gregorlingl commentedon May 4, 2009
I propose to update turtle.py with this new version 1.1 of the turtle
module.
Summary of changes:
a few bugfixes, with 1 - 5 lines of code changed for each;
these concern bugs that prevented turtle to run correctly
I've added four methods to the class TurtleScreeenBase:
_onkeypress(fun, key) (supplementing _onkeyrelease)
mainloop() (which is now a Screen-method and a function)
textinput(title, prompt)
numinput(title, prompt, default, minval, maxval)
the latter two remedy the complete lack of input methods
_onkey, an internal method name is changed to _onkeyrelease
I've added one method to the class TurtleScreen:
onkeypress(fun, key=None) implemented in analogy to the
already present onkey()
which got onkeyrelease as an alias.
I've changed several portions of the code that affect
the representation of the turtleshape thus making it
more compact (by removing some duplicated code) and more
powerful, i. e. by adding the possibility to apply
shearings to turtleshapes (in addition to the already present
scaling and rotating transformations). Thus now the full
range of (non singular) linear transformations is available.
New methods in class RawTurtle:
shearfactor(shear=None) set or get the shearfactor
shapetransform(t11, t12, t21, t22)
set or get the shape transform directly
get_shapepoly() return the polygon of the current shape
I've enhanced the functionality of tiltangle(angle=None)
to contain also that of settiltangle and I propose to
declare settiltangle as deprecated.
5. I've removed a lot of codelines that were commented out
during the process of transferring the module from 2.6
to 3.0
according do my proposition there and I strongly
recommend this change again, as the bug described is very
annoying, the fix is easy and no one proposed a better
solution.
For convenience I'll add the diff subsequently
Regards,
Gregor
gregorlingl commentedon May 4, 2009
Just to see what I've changed:
The unified diff from version 1.0 ( Revision 69847 )
to the proposed version 1.1b
(Should result in version 1.1 'final'ly)
loewis commentedon May 4, 2009
I won't have time to look into this soon.
birkenfeld commentedon May 4, 2009
Had a quick look over the patch, and couldn't find ab obvious problem
(except one -- you maybe want to comment out "print(_ver)" again).
Needs a docs patch, though.
gregorlingl commentedon May 4, 2009
I just wanted to submit the reply below. In the meantime Benjamin's
remark arrived. So perhaps the issue can be resolved successfully.
May I submit here one of the two example scripts I'd like to add to the
demos: tdemo_round_dance.py . Have a look at it and run it.
Just for fun - in this strained situation - I hope you enjoy it.
I'll prepare the patch for the docs and I'll submit it as soon as
possible, not later than tomorrow.
Of course the print(_ver) statement should be commented out.
Regards,
Gregor
-----------------------------------------------------------
So perhaps there is someone else who could do it.
I'd like to state decisively:
Version 1.1 contains significant amendments.
I tested it thoroughly
It would be a big advantage if others could test it also
during the 4 weeks of beta testing.
So I'd like to ask: Would it be practicable to put it
into 3.1b with the caveat to revert this adoption if it
turns out to have unrecoverable flaws?
I'd like to remind you that Martin even did significant
changes to version 1.0 only a few days before the final
release of Python2.6.
I know (and regret) that I submitted these changes rather late,
but it was four days ago that I asked Martin and also Raymond for
advice on how to proceed with the submission but regrettably with
no response. Unfortunately I'm a full time teacher and have to
do a lot of final exams these days. So I have only limited
resources to work on turtle development. Nevertheless
I'm anxious to only deliver valuable contributions.
I hope there is a way to accept these for now.
Regards
Gregor
gregorlingl commentedon May 4, 2009
Here the patch to comment out the print(_ver) statement
birkenfeld commentedon May 4, 2009
Gregor, I'll have a more thorough look and commit the patch before
3.1b1, if you promise to submit a patch to the documentation later --
that one can go in until a few days before final anyway.
gregorlingl commentedon May 5, 2009
Here is a patch for the documentation. It may contain some typos and/or
inaccuracies. I promise to check it and submit a patch if necessary
before final.
It contains also the announcement of two new demo scripts, the one
beeing round_dance submitted already, the other one being a nim game.
I'll submit it subsequently
Regards,
Gregor
gregorlingl commentedon May 5, 2009
The second demo script just announced
bitdancer commentedon May 5, 2009
Gregor, I applied my doctest fixups to turtle.rst in the py3k branch in
r72307. I've attached an updated version of your docpatch that applies
against this new revision.
birkenfeld commentedon May 5, 2009
OK, I committed turtle30_to_31.diff, and additionally commented the
print(_ver) out and updated the version in the comment at the file's
top, and committed issues5923.doc.patch in r72318.