Repository navigation
SystemError when __len__ returns a non-number #49387
Description
| BPO | 5137 |
|---|---|
| Nosy | @rhettinger, @pitrou, @benjaminp |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/benjaminp'
closed_at = <Date 2009-02-08.21:07:56.269>
created_at = <Date 2009-02-03.04:45:14.792>
labels = ['type-crash', 'release-blocker']
title = 'SystemError when __len__ returns a non-number'
updated_at = <Date 2009-02-10.06:55:34.148>
user = 'https://github.com/rhettinger'bugs.python.org fields:
activity = <Date 2009-02-10.06:55:34.148>
actor = 'hagen'
assignee = 'benjamin.peterson'
closed = True
closed_date = <Date 2009-02-08.21:07:56.269>
closer = 'benjamin.peterson'
components = []
creation = <Date 2009-02-03.04:45:14.792>
creator = 'rhettinger'
dependencies = []
files = ['12927', '12969', '12979', '12980']
hgrepos = []
issue_num = 5137
keywords = ['patch']
message_count = 8.0
messages = ['81024', '81338', '81386', '81393', '81395', '81402', '81418', '81531']
nosy_count = 4.0
nosy_names = ['rhettinger', 'pitrou', 'benjamin.peterson', 'hagen']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue5137'
versions = ['Python 3.0', 'Python 3.1']
Activity
rhettinger commentedon Feb 3, 2009
len(obj) is not happy when obj.__len__() returns a non-number.
benjaminp commentedon Feb 7, 2009
Here's patch that raises a TypeError like 2.x.
pitrou commentedon Feb 8, 2009
Wouldn't it be better to use PyNumber_AsSsize_t() instead, so as to
support all __index__-enabled objects?
benjaminp commentedon Feb 8, 2009
Yes, good idea.
pitrou commentedon Feb 8, 2009
I don't think you need to call PyNumber_Check() (unless you want to
customize the error message).
pitrou commentedon Feb 8, 2009
The patch is ok to me. (I assume all tests pass fine :-))
benjaminp commentedon Feb 8, 2009
Thanks for the reviews! Fixed in r69451.
hagen commentedon Feb 10, 2009
This also solves bpo-3729.