Repository navigation
telnetlib module broken by str to unicode conversion #47975
Description
| BPO | 3725 |
|---|---|
| Nosy | @amauryfa, @vstinner, @benjaminp |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/benjaminp'
closed_at = <Date 2008-10-15.20:54:40.089>
created_at = <Date 2008-08-29.12:43:46.004>
labels = ['library', 'type-crash', 'release-blocker']
title = 'telnetlib module broken by str to unicode conversion'
updated_at = <Date 2008-10-15.20:54:40.087>
user = 'https://bugs.python.org/hdima'bugs.python.org fields:
activity = <Date 2008-10-15.20:54:40.087>
actor = 'benjamin.peterson'
assignee = 'benjamin.peterson'
closed = True
closed_date = <Date 2008-10-15.20:54:40.089>
closer = 'benjamin.peterson'
components = ['Library (Lib)']
creation = <Date 2008-08-29.12:43:46.004>
creator = 'hdima'
dependencies = []
files = ['11788']
hgrepos = []
issue_num = 3725
keywords = ['patch']
message_count = 7.0
messages = ['72131', '72132', '74735', '74770', '74780', '74794', '74815']
nosy_count = 4.0
nosy_names = ['hdima', 'amaury.forgeotdarc', 'vstinner', 'benjamin.peterson']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue3725'
versions = ['Python 3.0']
Activity
hdima commentedon Aug 29, 2008
Simple example:
hdima commentedon Aug 29, 2008
I think only bytes need to be allowed for write() and read*() because of
low-level nature of Telnet. I can create a patch later.
vstinner commentedon Oct 14, 2008
I think that telnet should only use bytes (and not characters). For an
HTTP connection, the charset is only known after parsing the HTTP
headers. So telnet should use bytes, and your HTTP browser will
convert bytes to characters using the charset from the HTTP headers.
My patch only uses bytes for internal buffering and special codes
(IAC, DONT, ENCRYPT, etc.).
Example to test the library (Starwars, telnet, ISO-8859-1):
from telnetlib import Telnet
from sys import stdout
ipv4 = "towel.blinkenlights.nl"
ipv6 = "2001:980:ffe:1::42"
t = Telnet(ipv6, 23)
while True:
command = t.read_some()
command = str(command, "ISO-8859-1")
stdout.write(command)
Example to test the library (Google, HTTP, ASCII):
from telnetlib import Telnet
t = Telnet("www.google.com", 80)
t.write(b'GET / HTTP/1.0\r\n\r\n')
answer = t.read_all()
answer = str(answer, "ASCII")
print(answer)
benjaminp commentedon Oct 14, 2008
The patch looks pretty straightforward to me. If somebody else gives
their nod, I'll apply it.
amauryfa commentedon Oct 14, 2008
Yes, the patch is good.
I think that documentation (both Doc\library\telnetlib.rst and the
docstrings in telnetlib.py) should reflect the change, at least the code
samples.
hdima commentedon Oct 15, 2008
The patch is good. It's exactly what I told about in msg72132.
benjaminp commentedon Oct 15, 2008
Fixed in r66904.