Repository navigation
Reloading an extension module always leaks #47917
Description
| BPO | 3667 |
|---|---|
| Nosy | @loewis, @warsaw, @amauryfa, @benjaminp |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/benjaminp'
closed_at = <Date 2008-09-04.02:28:32.515>
created_at = <Date 2008-08-24.20:54:59.499>
labels = ['release-blocker']
title = 'Reloading an extension module always leaks'
updated_at = <Date 2008-09-04.02:28:32.514>
user = 'https://github.com/amauryfa'bugs.python.org fields:
activity = <Date 2008-09-04.02:28:32.514>
actor = 'benjamin.peterson'
assignee = 'benjamin.peterson'
closed = True
closed_date = <Date 2008-09-04.02:28:32.515>
closer = 'benjamin.peterson'
components = []
creation = <Date 2008-08-24.20:54:59.499>
creator = 'amaury.forgeotdarc'
dependencies = []
files = ['11289']
hgrepos = []
issue_num = 3667
keywords = ['patch', 'needs review']
message_count = 4.0
messages = ['71867', '72085', '72466', '72467']
nosy_count = 4.0
nosy_names = ['loewis', 'barry', 'amaury.forgeotdarc', 'benjamin.peterson']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue3667'
versions = ['Python 3.0']
Activity
amauryfa commentedon Aug 24, 2008
With python2.6, reloading extension modules does not always leak memory:
But with 3.0, reloading audioop leaks 60 references every time (seen in
test_unittest):
OK, many things cannot be reinitialized for C-written modules (static
variables &co), this is not the case for audioop. Furthermore, I thought
that the new module API was to support proper cleanup of modules
amauryfa commentedon Aug 28, 2008
The fix is actually simple: _PyImport_FindExtension() used to return a
borrowed reference, the "strong" reference being stored in the
PyImport_GetModuleDict() dictionary. All paths should behave the same.
See attached patch.
(for unit tests, run for example
regrtest.py -R:: test_site
)
warsaw commentedon Sep 4, 2008
The patch looks good. Benjamin will commit this.
benjaminp commentedon Sep 4, 2008
Fixed in r66204.