Repository navigation
readline module Crashs on OpenBSD/amd64 #47895
Description
| BPO | 3645 |
|---|---|
| Nosy | @gpshead |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/gpshead'
closed_at = <Date 2008-09-06.21:56:41.885>
created_at = <Date 2008-08-22.05:41:07.662>
labels = ['easy', 'library', 'type-crash', 'release-blocker']
title = 'readline module Crashs on OpenBSD/amd64'
updated_at = <Date 2008-09-06.21:56:41.883>
user = 'https://bugs.python.org/henryprecheur'bugs.python.org fields:
activity = <Date 2008-09-06.21:56:41.883>
actor = 'gregory.p.smith'
assignee = 'gregory.p.smith'
closed = True
closed_date = <Date 2008-09-06.21:56:41.885>
closer = 'gregory.p.smith'
components = ['Library (Lib)']
creation = <Date 2008-08-22.05:41:07.662>
creator = 'henry.precheur'
dependencies = []
files = ['11206']
hgrepos = []
issue_num = 3645
keywords = ['patch', '64bit', 'easy']
message_count = 6.0
messages = ['71723', '71724', '72375', '72465', '72538', '72710']
nosy_count = 3.0
nosy_names = ['gregory.p.smith', 'henry.precheur', 'rpetrov']
pr_nums = []
priority = 'release blocker'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue3645'
versions = ['Python 2.6', 'Python 2.5', 'Python 3.0']
Activity
henryprecheur commentedon Aug 22, 2008
$ python2.5 Python 2.5.2 (r252:60911, Jun 16 2008, 15:20:47) [GCC 3.3.5 (propolice)] on openbsd4 Type "help", "copyright", "credits" or "license" for more information. >>> def complete(text, state): ... print 'complete %r %d' % (text, state) ... if text == 'i' and state == 0: ... return 'import' ... else: ... return None ... >>> import readline; readline.parse_and_bind("tab: complete") >>> readline.set_completer(complete) >>> i<TAB> # <TAB> is press the tab key complete 'i' 0 complete 'i' 1 Segmentation fault (core dumped) The problem is that Python is using a function present in libreadline but not declared in readline/readline.h: completion_matches. Instead of using rl_completion_matches. Therefor the return type of completion_matches was an int which is 32bits on amd64 but the function was supposed to returns a pointer which is 64 bits. So when the pointer had a "high" value, it was truncated. The problem is fixed by adding libcurses to AC_CHECK_LIB when checking for functions in libreadline since libreadline depends on curses. This makes Python use the correct functions declared on readline.h with a correct return type.Patch is attached.
(Others versions of Python should also be affected)
henryprecheur commentedon Aug 22, 2008
Looks like this patch should also be applied to python 2.6 & 3.
I did not tested but the patch is trivial enough to be applied without
too much fear of breaking something ;)
gpshead commentedon Sep 3, 2008
committed to trunk (2.6) in r66179. This should be back ported to
release25-maint and automagically merged into py3k.
can someone with OpenBSD confirm that this has indeed fixed the problem?
if so i'll do the 25 backport and mark it as closed instead of pending.
henryprecheur commentedon Sep 4, 2008
I just compiled the latest version of trunk. The problem seems to be
fixed. And according to config.log & nm, readline.so is linked with the
right function.
rpetrov commentedon Sep 4, 2008
may bpo-1204 is more general
gpshead commentedon Sep 6, 2008
true, bpo-1204 is more general. i'll leave this in but it can be
removed once the better general fix is in with 1204. i won't backport
this one.