xml.sax.parser() doesn't terminate when given a filename #46753

Activity

1. mark-summerfield commented on Mar 28, 2008

   

   mark-summerfieldmannequin

   on Mar 28, 2008

   MannequinAuthor

   More actions

   The tiny program at the end of this message runs under Python 2.5 &
   30a3. Under 2 it gives the following output:

   : python sax.py test.xml
   ('+', u'document')
   ('+', u'outer')
   ('+', u'inner')
   ('-', u'inner')
   ('-', u'outer')
   ('-', u'document')
   Done

   Under 3 it does not terminate:
   : python3 sax.py test.xml
   + document
   + outer
   + inner
   - inner
   - outer
   - document
   Traceback (most recent call last):
     File "sax.py", line 19, in <module>
       parser.parse(sys.argv[1])
     File "/home/mark/opt/python30a3/lib/python3.0/xml/sax/expatreader.py",
   line 107, in parse
       xmlreader.IncrementalParser.parse(self, source)
     File "/home/mark/opt/python30a3/lib/python3.0/xml/sax/xmlreader.py",
   line 124, in parse
       buffer = file.read(self._bufsize)
     File "/home/mark/opt/python30a3/lib/python3.0/io.py", line 774, in read
       current = self.raw.read(to_read)
   KeyboardInterrupt

   The xml.sax.parser() function seems to work fine if you give it an open
   file object and close the file after the call. But the documentation
   says you can give it a filename, but if you do that the parser does not
   terminate in Python 3 although it works fine in Python 2.

   # sax.py
   import sys
   import xml.sax
   BUG = True
   class SaxHandler(xml.sax.handler.ContentHandler):
       def startElement(self, name, attributes):
           print("+", name)
       def endElement(self, name):
           print("-", name)
   handler = SaxHandler()
   parser = xml.sax.make_parser()
   parser.setContentHandler(handler)
   if BUG:
       parser.parse(sys.argv[1])
   else:
       fh = open(sys.argv[1], encoding="utf8")
       parser.parse(fh)
       fh.close()
   print("Done")
   # end of sax.py

   Here is the test file:

   <?xml version="1.0" encoding="UTF-8"?>
   <document>
   <outer>
   <inner>
   </inner>
   </outer>
   </document>
2. mark-summerfield

   added

   topic-XML

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on Mar 28, 2008
3. tiran commented on Mar 28, 2008

   

   tiran

   on Mar 28, 2008

   Member

   More actions

   I had to disable three unit tests in test_sax. We didn't noticed the
   problem before because the tests weren't actually run. The three tests
   are marked clearly with XXX and FIXME.
4. benjaminp

   added

   release-blocker

   on Aug 21, 2008
5. devdanzin commented on Aug 28, 2008

   

   devdanzinmannequin

   on Aug 28, 2008

   Mannequin

   More actions

   ISTM that this release blocker can be solved by changing
   xml.sax.xmlreader.py line 122 from:
   while buffer != "":
   to
   while buffer != b"":
6. tiran commented on Aug 28, 2008

   

   tiran

   on Aug 28, 2008

   Member

   More actions

   I've a better idea:

       while buffer: 

   It's faster and works for both empty bytes and str.

   The patch fixes the issue and re-enables three unit tests.
7. benjaminp commented on Sep 1, 2008

   

   benjaminp

   on Sep 1, 2008

   Contributor

   More actions

   The patch looks great. (I love enabling disabled tests!)
8. devdanzin commented on Sep 1, 2008

   

   devdanzinmannequin

   on Sep 1, 2008

   Mannequin

   More actions

   Looks like this is a duplicate of bpo-3590, so this patch fixes two
   release blockers ;)
9. warsaw commented on Sep 4, 2008

   

   warsaw

   on Sep 4, 2008

   Member

   More actions

   Benjamin will commit this.
10. warsaw

    assigned

    benjaminp

    on Sep 4, 2008
11. benjaminp commented on Sep 4, 2008

    

    benjaminp

    on Sep 4, 2008

    Contributor

    More actions

    Applied in r66203.
12. benjaminp

    closed this as completedon Sep 4, 2008
13. ezio-melotti

    transferred this issue fromon Apr 10, 2022