Repository navigation
Expose non-blocking callbackAPI in readline module #45135
Description
| BPO | 1744456 |
|---|---|
| Nosy | @tiran, @ned-deily, @vadmium |
| Superseder | |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2013-11-17.15:27:51.350>
created_at = <Date 2007-06-27.20:37:52.000>
labels = ['extension-modules', 'type-feature']
title = 'Expose non-blocking callbackAPI in readline module'
updated_at = <Date 2015-08-02.00:47:16.753>
user = 'https://bugs.python.org/strank'bugs.python.org fields:
activity = <Date 2015-08-02.00:47:16.753>
actor = 'martin.panter'
assignee = 'none'
closed = True
closed_date = <Date 2013-11-17.15:27:51.350>
closer = 'christian.heimes'
components = ['Extension Modules']
creation = <Date 2007-06-27.20:37:52.000>
creator = 'strank'
dependencies = []
files = ['8068']
hgrepos = []
issue_num = 1744456
keywords = ['patch']
message_count = 5.0
messages = ['52806', '116695', '116707', '203192', '247842']
nosy_count = 5.0
nosy_names = ['christian.heimes', 'strank', 'ned.deily', 'BreamoreBoy', 'martin.panter']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'needs patch'
status = 'closed'
superseder = '1175004'
type = 'enhancement'
url = 'https://bugs.python.org/issue1744456'
versions = ['Python 3.4']
Activity
strank commentedon Jun 27, 2007
Expose the callback API of GNU readline.
Patch contains changes to readline.c and libreadline.tex,
I did not find a unit-test for readline so there are no tests.
One of the readline functions (callback_read_char) can potentially call abort(). This can happen on the interactive prompt, but I think that this is not a problem, since using this API from the interactive prompt (which itself uses it) does not make sense anyway.
cheers,
stefan
[-]Patch for feat. 713877 Expose callbackAPI in readline module[/-][+]Patch for feat. 1713877 Expose callbackAPI in readline module[/+][-]Patch for feat. 713877 Expose callbackAPI in readline module[/-][+]Patch for feat. 1713877 Expose callbackAPI in readline module[/+]BreamoreBoy commentedon Sep 17, 2010
Is there anyone who'd like to see this functionality exposed who could review this C code patch?
ned-deily commentedon Sep 17, 2010
This appears to be a duplicate of bpo-1175004; both supply patches to implement readline callbacks. Suggest that anyone moving forward with this review both patches.
tiran commentedon Nov 17, 2013
Closing as duplicate
vadmium commentedon Aug 2, 2015
I don’t think this is a duplicate. The patch here wraps the non-blocking “alternate interface” <https://cnswww.cns.cwru.edu/php/chet/readline/readline.html#SEC41\>: rl_callback_read_char() etc. The patch in bpo-1175004 wraps other APIs, including rl_add_defun() <https://cnswww.cns.cwru.edu/php/chet/readline/readline.html#SEC30\>. So if someone was interested in pushing this forward, perhaps it could be reopened.
[-]Patch for feat. 1713877 Expose callbackAPI in readline module[/-][+]Expose non-blocking callbackAPI in readline module[/+][-]Patch for feat. 1713877 Expose callbackAPI in readline module[/-][+]Expose non-blocking callbackAPI in readline module[/+]