Skip to content

Possible null pointer dereference of variable args in _PyPegen_collect_call_seqs #126240

New issue
New issue
Closed
Closed
Possible null pointer dereference of variable args in _PyPegen_collect_call_seqs#126240
Assignees
picnixz
Labels
3.12only security fixes3.13only security fixes3.14bugs and security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)topic-parsertype-crashA hard crash of the interpreter, possibly with a core dump

Description

@federicovalenso
federicovalenso
opened on Oct 31, 2024

Crash report

What happened?

args can be NULL as a result of _Py_asdl_expr_seq_new, and then dereference happens.

Return value of _Py_asdl_expr_seq_new` is usually checked, for example here and in other places.

CPython versions tested on:

3.11

Operating systems tested on:

Linux

Output from running 'python -VV' on the command line:

No response

Linked PRs

Activity

  1. federicovalenso
    added
    type-crashA hard crash of the interpreter, possibly with a core dump
    on Oct 31, 2024
  2. picnixz
    self-assigned this
    on Oct 31, 2024

  3. picnixz commented on Oct 31, 2024

    @picnixz
    picnixz
    on Oct 31, 2024
    Member

    Thanks for this one! I'll hunt other missing NULL check in PyPegen at the same time.

  4. picnixz
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    topic-parser
    3.12only security fixes
    3.13only security fixes
    3.14bugs and security fixes
    on Oct 31, 2024
  5. sobolevn
    added a commit that references this issue on Oct 31, 2024

    gh-126240: handle `NULL` returned by `_Py_asdl_expr_seq_new` (#126241)

    94639f6
  6. miss-islington
    added a commit that references this issue on Oct 31, 2024

    pythongh-126240: handle `NULL` returned by `_Py_asdl_expr_seq_new` (p…

    535c672
  7. sobolevn
    added 2 commits that reference this issue on Oct 31, 2024

    [3.13] gh-126240: handle `NULL` returned by `_Py_asdl_expr_seq_new` (G…

    8004238

    [3.12] gh-126240: handle `NULL` returned by `_Py_asdl_expr_seq_new` (G…

    3416ffa

  8. picnixz commented on Oct 31, 2024

    @picnixz
    picnixz
    on Oct 31, 2024
    Member

    Closing since completed and backported. Thanks for the report!

  9. picnixz
    closed this as completedon Oct 31, 2024
  10. picnixz
    added a commit that references this issue on Dec 8, 2024

    pythongh-126240: handle `NULL` returned by `_Py_asdl_expr_seq_new` (p…

    af34ffb
  11. ebonnal
    added a commit that references this issue on Jan 12, 2025

    pythongh-126240: handle `NULL` returned by `_Py_asdl_expr_seq_new` (p…

    c0728c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

3.12only security fixes3.13only security fixes3.14bugs and security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)topic-parsertype-crashA hard crash of the interpreter, possibly with a core dump

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions