Activity

1. XuehaiPan

   added

   type-featureA feature request or enhancementA feature request or enhancement

   on Oct 2, 2023
2. AlexWaygood commented on Oct 2, 2023

   

   AlexWaygood

   on Oct 2, 2023

   Last edited by AlexWaygood

   Member

   More actions

   cc. @serhiy-storchaka
3. XuehaiPan commented on Oct 2, 2023

   

   XuehaiPan

   on Oct 2, 2023

   ContributorAuthor

   More actions

   I created a PR to resolve this.
4. serhiy-storchaka commented on Oct 2, 2023

   

   serhiy-storchaka

   on Oct 2, 2023

   Member

   More actions

   PyStructSequence with unnamed fields is a special case. Currently the only such structure is os.stat_result. Accessible by name fields st_atime, st_mtime and st_ctime are float values. Corresponding unnamed fields 7-9 are integer values. It is an old trick for compatibility. __replace__() can replace named fields, but unnamed fields will keep the old value. Integer and float value will be de-synchronized, and the code that reads unnamed fields will work incorrectly.

   The simplest solution is to disable __replace__() for PyStructSequence with unnamed fields. Such structures can even be deprecated, but this is a different issue.

   There may be a special implementation of __replace__() for os.stat_result, which derives values for unnamed fields from corresponding values for named fields. But float value can be less precise than integer value, because it has limited precision. So it needs to take into account *_ns fields. It is separate very complex issue.
5. XuehaiPan commented on Oct 2, 2023

   

   XuehaiPan

   on Oct 2, 2023

   ContributorAuthor

   More actions

   PyStructSequence with unnamed fields is a special case. Currently the only such structure is os.stat_result. Accessible by name fields st_atime, st_mtime and st_ctime are float values. Corresponding unnamed fields 7-9 are integer values. It is an old trick for compatibility. __replace__() can replace named fields, but unnamed fields will keep the old value. Integer and float value will be de-synchronized, and the code that reads unnamed fields will work incorrectly.

   I can confirm this is a bug for PyStructSequence with unnamed fields if we rely on __reduce__(). But I'm not sure why pickle.loads(pickle.dumps(stat)) works fine for os.stat_result.

   The simplest solution is to disable __replace__() for PyStructSequence with unnamed fields. Such structures can even be deprecated, but this is a different issue.

   I agree to raise an error for this (e.g., TypeError) since os.stat_result is the only case to have unnamed fields.

   There may be a special implementation of __replace__() for os.stat_result, which derives values for unnamed fields from corresponding values for named fields. But float value can be less precise than integer value, because it has limited precision. So it needs to take into account *_ns fields. It is separate very complex issue.

   I think it's better to disable __replace__() for PyStructSequence with unnamed fields.
6. serhiy-storchaka

   closed this as completedin #110223on Oct 4, 2023
7. serhiy-storchaka

   added a commit that references this issue on Oct 4, 2023

   gh-110222: Add support of PyStructSequence in copy.replace() (GH-110223)

   3bbe3b7
8. Glyphack

   added a commit that references this issue on Sep 2, 2024

   pythongh-110222: Add support of PyStructSequence in copy.replace() (p…

   ...

   87f3375