Repository navigation
Windows os.path.isdir has different signature #109782
Description
Bug report
Bug description:
In this PR #101324 and issue #101196 the optimized methods of isdir and isfile were added for windows. If not available they will fall back to genericpath implementations.
The issue with isdir is that this introduced a different signature compared to genericpath:
# in genericpath.py
def isdir(s) -> bool: ...
# in optimized nt module
def isdir(path) -> bool: ...I'm not sure if this was intentional to have different signatures depending on the platform, and there's any possibility to fix this now. Ref: python/typeshed#10751
CPython versions tested on:
3.12
Operating systems tested on:
Linux
Activity
sobolevn commentedon Sep 23, 2023
CC @zooba and @mdboom
pythongh-109782 Update NT os.path.isdir signature
pythongh-109782 Update NT os.path.isdir signature
gh-109782: Ensure `os.path.isdir` has the same signature on all platf…
pythongh-109782: Ensure `os.path.isdir` has the same signature on all…
pythongh-109782: Ensure `os.path.isdir` has the same signature on all…
[3.12] gh-109782: Ensure `os.path.isdir` has the same signature on al…
pythongh-109782: Ensure `os.path.isdir` has the same signature on all…