Repository navigation
email.parser header-only parsing records MultipartInvariantViolationDefect for valid multipart emails #106186
Description
Bug report
A valid multipart email message, when parsed with email.parser.HeaderParser(policy=email.policy.default) will record a email.errors.MultipartInvariantViolationDefect.
If the parser isn't going to attempt to parse the message body, it shouldn't report that as a defect.
Simple test script:
import email.parser
import email.policy
email_str = '''\
Date: 01 Jan 2001 00:01+0000
From: [email protected]
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary=autocracy
--autocracy
Content-Type: text/plain
By hanging on to outdated imperialist dogma which perpetuates the economic and
social differences in our society.
--autocracy
Content-Type: text/html
<html><body><p>By hanging on to outdated imperialist dogma which perpetuates
the economic and social differences in our society.</p></body></html>
--autocracy--
'''
full_parser = email.parser.Parser(policy=email.policy.default)
parsed_email_full = full_parser.parsestr(email_str)
print(parsed_email_full.defects) # Prints [] as expected
header_parser = email.parser.HeaderParser(policy=email.policy.default)
parsed_email_headers_only = header_parser.parsestr(email_str)
print(parsed_email_headers_only.defects) # Prints [MultipartInvariantViolationDefect()]Your environment
- Debian 12
- Raspberry Pi 4 (arm64)
- Python 3.11.2 (Debian package 3.11.2-1+b1)
Linked PRs
- gh-106186: Don't report MultipartInvariantViolationDefect for valid multipart emails when parsing header only #107016
- [3.12] gh-106186: Don't report MultipartInvariantViolationDefect for valid multipart emails when parsing header only (GH-107016) #107111
- [3.11] gh-106186: Don't report MultipartInvariantViolationDefect for valid multipart emails when parsing header only (GH-107016) #107112
Activity
htsedebenham commentedon Jul 22, 2023
I believe this is the expected behaviour. Per the documentation,
HeaderParseracts likeParserwithheadersonly=True. Modifying the test script as follows, the printed value is[MultipartInvariantViolationDefect()].htsedebenham commentedon Jul 22, 2023
I see the issue, looking into it now.
ambv commentedon Jul 23, 2023
Per documentation of
Parser.parse():From this reading, the issue is valid and the fix in the attached PR is the correct bugfix.
gh-106186: Don't report MultipartInvariantViolationDefect for valid m…
pythongh-106186: Don't report MultipartInvariantViolationDefect for v…
pythongh-106186: Don't report MultipartInvariantViolationDefect for v…
[3.12] gh-106186: Don't report MultipartInvariantViolationDefect for …
[3.11] gh-106186: Don't report MultipartInvariantViolationDefect for …
pythongh-106186: Don't report MultipartInvariantViolationDefect for v…
pythongh-106186: Don't report MultipartInvariantViolationDefect for v…