Skip to content

test_typing.NewTypeTests can be improved #105431

Closed
Closed
test_typing.NewTypeTests can be improved#105431
Assignees
sobolevn
Labels
testsTests in the Lib/test dirtopic-typingtype-bugAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on Jun 7, 2023

After https://github.com/python/cpython/pull/103764/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305dR6452 NewTypeTests has two unused methods:

  • cleanup, it is even provided in its parent class: BaseTestCase
  • teardown, because it does not need to clean things up, tests with -R 3:3 prove that

I will send a PR to clean things up.

Linked PRs

Activity

  1. sobolevn
    added
    type-bugAn unexpected behavior, bug, or error
    testsTests in the Lib/test dir
    topic-typing
    on Jun 7, 2023
  2. sobolevn
    self-assigned this
    on Jun 7, 2023
  3. sobolevn
    added a commit that references this issue on Jun 7, 2023

    pythongh-105431: Remove unused stuff from `test_typing.NewTypeTests`

    e444cfc
  4. AlexWaygood
    added a commit that references this issue on Jun 8, 2023

    gh-105431: Remove unused stuff from `test_typing.NewTypeTests` (#105432)

    9d35a71
  5. miss-islington
    added a commit that references this issue on Jun 8, 2023

    pythongh-105431: Remove unused stuff from `test_typing.NewTypeTests` (p…

    ec713b8
  6. AlexWaygood
    added a commit that references this issue on Jun 8, 2023

    [3.12] gh-105431: Remove unused stuff from `test_typing.NewTypeTests` (…

    2b6f475
  7. AlexWaygood
    closed this as completedon Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

testsTests in the Lib/test dirtopic-typingtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions