Repository navigation
GH-5550 was linked to bpo-12345 #223
Description
The bot added links to python/cpython#5550 and its backports in unrelated bpo-12345. But I haven't found references to bpo-12345 neither in the PR comments, no in corresponding commit (5bb9692575f10f4a7c7f1c2c0c70956baf6d5c23).
Activity
Mariatta commentedon Feb 25, 2018
Sorry, I've caused this issue.
In https://github.com/python/cpython/pull/5841/files I modified the PR template, and referencing bpo-12345 as a comment inside the pull request. If the comment is not deleted, the bpo webhook picks that up and the links the PR to bpo-12345.
I'll work on modifying the PR template.
Update PR template file, don't reference bpo 12345
Mariatta commentedon Feb 25, 2018
I changed the PR template to reference bpo-123 (doesn't exist). Does that sound ok?
brettcannon commentedon Feb 25, 2018
I say just have the comment reference
bpo-NNNNand completely avoid the potential issue.Mariatta commentedon Feb 25, 2018
Thanks, I've removed the sentence that says bpo-123.
Update PR template file, don't reference bpo 12345 (GH-5897)