Skip to content

Only check for the maintenance branch prefix. - #125

Merged
Mariatta merged 2 commits into
python:masterfrom
Mariatta:issue-124
Aug 4, 2018
Merged

Mariatta merged 2 commits into
python:masterfrom
Mariatta:issue-124

Conversation

@Mariatta

@Mariatta Mariatta commented Jul 29, 2018 •

Copy link
Copy Markdown
Member

Maybe with this, we can make it a required status check.

  • Make it required after deployed.

Closes #124

@codecov

codecov Bot commented Jul 29, 2018 •

Copy link
Copy Markdown

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #125   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines        1482   1483    +1     
  Branches       85     85           
=====================================
+ Hits         1482   1483    +1
Impacted Files Coverage Δ
tests/test_backport.py 100% <100%> (ø) ⬆️
bedevere/backport.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b295fc6...4f51e7c. Read the comment docs.

Comment thread bedevere/backport.py Outdated
match the backport PR pattern, then post a failure status.
match the maintenance branch PR pattern, then post a failure status.

The maintenance branch PR has to start with [X.Y]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe wrap "[X.Y]" in quotes or something to make it stand out more?

@Mariatta
Mariatta merged commit 30166b0 into python:master Aug 4, 2018
@Mariatta
Mariatta deleted the issue-124 branch August 4, 2018 14:59
@Mariatta

Mariatta commented Aug 4, 2018 •

Copy link
Copy Markdown
Member Author

Thanks! This status is now required for the maintenance branches: 2.7, 3.6, 3.7.
I didn't change it for 3.4, 3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants