Repository navigation
Highlight improperly NEWS.d entry files in the news check failure message. #57
Description
In PR python/cpython#3274 bedevere correctly kept the "No news entry in Misc/NEWS.d or "skip news" label found" warning on the PR. Presumably because it knew I had a typo in my NEWS.d filename (.bps- instead if .bpo-)?
I misunderstood its warning as just not noticing that I had added a NEWS.d file later. Could its warning text highlight unexpected filenames within a NEWS.d directory? or is this not worth doing? (I've learned - the question is how many others will learn the hard way)
Activity
brettcannon commentedon Sep 19, 2017
As of right now the check is a regex match for the full path of the file:
bedevere/bedevere/news.py
Line 43 in 48cc643
It could be changed to do a
str.startswith()check to make sure that a file exists in the proper directory in theelseclause and then do a separate check for the filename itself after that. Both of those checks could have their own failure states that are more explicit as to why they were triggered.