Skip to content

backport check fails for Python 2.7 fix that's not a backport #124

Closed

Description

@encukou

python/cpython#8449 is a fix for a bug that doesn't appear in Python 3. There's no corresponding PR for master. But, Bedevere's backport check sees a PR for a maintenance branch, and insists that there should be a (GH-XXX) note in the title.

I didn't find guidance for this specific case in the devguide, but I think the correct thing to do is to merge without the (GH-XXX) note, ignoring the status check.

Activity

  1. encukou commented on Jul 28, 2018

    @encukou
    MemberAuthor

    I just noticed this is already being discussed in python/core-workflow#211

  2. terryjreedy commented on Jul 28, 2018

    @terryjreedy
    Member

    I just added python/core-workflow#278, suggesting a 'skip backport' label for this situation.

  3. Mariatta commented on Jul 29, 2018

    @Mariatta
    Member

    This status check is optional so you can still merge the PR.

    I think for now I'll just drop the check for (GH-NNNN), and only checking for [X.Y], so we don't need a new label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions