More consistent LICENSE and CODE_OF_CONDUCT usage#234
Merged
Conversation
…NDUCT usage Use uppercase and fixed-pitch when references to license and code of conduct are more likely references to actual files. (No formatting added in alt text.) Also tweak a few grammatical issues.
Member
|
@all-contributors please add @ptressel for code, review |
Contributor
|
I've put up a pull request to add @ptressel! 🎉 |
ucodery
approved these changes
Apr 10, 2024
Member
|
@ucodery i'm totally happy for you to merge these types of pr's as you feel comfortable! i'll go ahead and merge this one. I think the only time we want to have a broader review is if we're changing content . So for instance it was helpful to have ofek review the hatch content since we were updating things - he ensured it was accurate. Or if we add a new section or page to the guide we want to let our community know and have an open review period. but if the changes are fixes like this - we can review and merge :) thank you for this approval. now ! |
lwasser
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use uppercase and fixed-pitch when references to license and code of conduct are more likely references to actual files. (No formatting added in alt text.) Also tweak a few grammatical issues.