Fix crash#44
Merged
Merged
Conversation
Owner
|
@philipturner Hi! Could you add some tests for |
Contributor
Author
|
I added a test. I really only think one test is necessary because we're just ensuring the crash doesn't happen. Tests for subclassing will test |
Contributor
Author
|
@pvieito how do we fix the CI issue on Windows? Update: The CI issue seems to be fixed. Can you be sure it's not something flaky? |
bwbemb
pushed a commit
to bwbemb/PythonKit
that referenced
this pull request
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I set Python to use 3.9 instead of 3.10, it crashes upon materializing a
PythonFunction's object. The culprit is thePyCFunction_Newfunction, as documented in clj-python/libpython-clj#105. We can work around this by callingPyCFunction_NewExand passingnilinto the last parameter. This workaround should stay permanent because people might use Python 3.9 in the future.