Skip to content

Revert add support for non-returning functions#43

Merged
pvieito merged 1 commit into
pvieito:masterfrom
philipturner:patch-3
Jan 21, 2022
Merged

Revert add support for non-returning functions#43
pvieito merged 1 commit into
pvieito:masterfrom
philipturner:patch-3

Conversation

@philipturner

@philipturner philipturner commented Jan 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

My previous PR stops Swift from type-inferring the function signature. Previously, this would compile successfully:

let myFunction = PythonFunction { (params: Array) in
    print(params.debugDescription)
    return Python.None
}

Now, there's a compile-time error because init(_:) is ambiguous.

@philipturner philipturner mentioned this pull request Jan 21, 2022
Merged
@pvieito pvieito merged commit 56ed7e2 into pvieito:master Jan 21, 2022
bwbemb pushed a commit to bwbemb/PythonKit that referenced this pull request Apr 6, 2026
@pvieito
Merge pull request pvieito#43 from philipturner/patch-3
446f66d 
Revert add support for non-returning functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@philipturner @pvieito