Skip to content

Alternative using NoShow#124

Closed
sigma-andex wants to merge 1 commit into
purescript-spec:masterfrom
sigma-andex:no-show
Closed

Alternative using NoShow#124
sigma-andex wants to merge 1 commit into
purescript-spec:masterfrom
sigma-andex:no-show

Conversation

@sigma-andex

@sigma-andex sigma-andex commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

See discussion in #123

@fsoikin

fsoikin commented Oct 21, 2022

Copy link
Copy Markdown
Member

Looks like you based this on an outdated branch. I think you'll need to rebase.

@i-am-the-slime

i-am-the-slime commented Oct 21, 2022

Copy link
Copy Markdown
Member

Wait I didn't look at this probably, do we need a new typeclass here?
Can't we just have:

instance Show (NoShow a) where
  show (NoShow x) = unsafeStringify x

@sigma-andex

Copy link
Copy Markdown
Contributor Author

Closing this in favour of #125 that includes your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants