Skip to content
This repository was archived by the owner on Oct 4, 2020. It is now read-only.

Add code from eff-functions#18

Merged
garyb merged 2 commits into
masterfrom
eff-fns
Mar 31, 2017
Merged

Add code from eff-functions#18
garyb merged 2 commits into
masterfrom
eff-fns

Conversation

@paf31

@paf31 paf31 commented Mar 31, 2017

Copy link
Copy Markdown
Contributor

The code is copied verbatim, just changing the module name and adding some spacing in the comments.

@hdgarrood The original code has no license file, so I inferred the MIT license from the bower.json file? I'll add that to the LICENSE file here if you can just confirm that's okay.

@hdgarrood

Copy link
Copy Markdown
Contributor

Yep, that's fine by me.

@garyb garyb merged commit 06d02be into master Mar 31, 2017
@garyb garyb deleted the eff-fns branch March 31, 2017 10:47
@paf31

paf31 commented Mar 31, 2017

Copy link
Copy Markdown
Contributor Author

Actually, @hdgarrood, would you mind modifying the LICENSE file if you'd like it to be modified?

I think we should also discuss what the copyright notices should say/mean, at some point. It's not clear to me what "PureScript" identifies.

@hdgarrood

Copy link
Copy Markdown
Contributor

I'm happy leaving the license file in this repo as it is regarding these changes.

In the longer term, do you think it would make sense to list contributors' names instead of just writing "PureScript"?

@paf31

paf31 commented Mar 31, 2017

Copy link
Copy Markdown
Contributor Author

Yes, I would prefer that. I've been thinking the same recently :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants