This repository was archived by the owner on Oct 4, 2020. It is now read-only.
Add dropEffect getter and setter on DataTransfer#140
Merged
Conversation
fehrenbach
force-pushed
the
dropeffect
branch
from
6405d67 to
8194cd6
Compare
garyb
suggested changes
Jan 20, 2018
garyb
left a comment
garyb
left a comment
Member
There was a problem hiding this comment.
Your PR to Halogen reminded me of this one that has been outstanding for ages. Sorry about the delay!
| "copy" -> Copy | ||
| "move" -> Move | ||
| "link" -> Link | ||
| "none" -> None |
Member
There was a problem hiding this comment.
unsafePartialBecause is problematic (purescript/purescript-partial#7), could you use crashWith in an _ case, and then unsafePartial the case instead please?
|
|
||
| foreign import dropEffectImpl :: forall eff. DataTransfer -> Eff (dom :: DOM | eff) String | ||
|
|
||
| data DropEffect = None | Copy | Move | Link |
Member
There was a problem hiding this comment.
Could you add derived instances for Eq and Ord for this too please?
Contributor
Author
|
No worries. What kind of heathen makes pull requests on Christmas Day anyways? ;) Thanks for the review. I addressed your remarks and sorted the cases while I was at it. |
Member
|
Thanks! |
garyb
approved these changes
Jan 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.