Update for react-15#99
Merged
Merged
Conversation
Author
|
fixes #95 |
Contributor
|
This looks good to me. Have you been able to test it on any projects? @ethul Any thoughts on this? |
Author
|
Yes, I did with https://github.com/coot/purescript-isomorphic-react-example Later I can push the testing branch. The react warning about 'createClass' is gone. |
Contributor
|
I think this looks good. Thanks for the update!
…On Tue, Jun 27, 2017 at 01:54 Coot ***@***.***> wrote:
Yes, I did with
https://github.com/coot/purescript-isomorphic-react-example
Later I can push the testing branch. The react warning about 'createClass'
is gone.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#99 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVYy-QFH7ksnQJRBJGicpPkzduv80o2ks5sIJkIgaJpZM4OEFv9>
.
|
Contributor
|
Thanks! |
Author
|
There is a typo in the release notes: it's an update for react-15, react-16 is still in development, though people are already using it. |
Contributor
|
Fixed. Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bindings now require to install
create-react-classalongside withreact. This suppresses a warning in react-15. React-16 will not allow to useReact.createClassand it's migrating towards react classes.