Conversation
Contributor
|
I think it looks good; however, would something like "PureScript Contrib"
make sense?
…On Thu, Jun 8, 2017 at 20:47 Phil Freeman ***@***.***> wrote:
Assigned #98
<#98> to @ethul
<https://github.com/ethul>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVYy2gI7DNISR4PtUeTdq_0EOHNGdv7ks5sCJY-gaJpZM4N0yGq>
.
|
Contributor
Author
|
I would actually prefer to assign copyright by name to everyone involved, so it's completely clear, but those names would probably have to go in a separate file since there are a few at this point. |
Contributor
|
Okay. Sounds good.
…On Thu, Jun 8, 2017 at 20:57 Phil Freeman ***@***.***> wrote:
I would actually prefer to assign copyright by name to everyone involved,
so it's completely clear, but those names would probably have to go in a
separate file since there are a few at this point.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#98 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVYy8Qc7Oignz2hkti6TKzdV59SYFEXks5sCJiVgaJpZM4N0yGq>
.
|
joneshf
approved these changes
Jun 9, 2017
Contributor
Author
|
@andreypopp What do you think? |
Contributor
|
Sorry for not replying earlier. I have no concerns. The MIT license is what I intended actually. |
Contributor
Author
|
Thanks everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #97
@ethul @andreypopp @joneshf Does the attribution in particular look good?