Skip to content

change structure & add laws for enums#1

Merged
garyb merged 1 commit into
purescript:masterfrom
jdegoes:ready/sane-enums
Oct 12, 2014
Merged

change structure & add laws for enums#1
garyb merged 1 commit into
purescript:masterfrom
jdegoes:ready/sane-enums

Conversation

@jdegoes

@jdegoes jdegoes commented Oct 12, 2014

Copy link
Copy Markdown
Contributor

Review by @garyb.

@garyb

garyb commented Oct 12, 2014

Copy link
Copy Markdown
Member

Thanks, this module has needed some love since the start. It was only thrown in for DateTime originally so was never properly considered (and that module needs work as well now I think of it).

I guess it will be a little more effort to define an Enum instance now, but I think it will be worth it.

garyb added a commit that referenced this pull request Oct 12, 2014
change structure & add laws for enums
@garyb garyb merged commit 958f7fb into purescript:master Oct 12, 2014
@paf31

paf31 commented Oct 12, 2014

Copy link
Copy Markdown
Contributor

Looks good, thanks.

@paf31

paf31 commented Oct 12, 2014

Copy link
Copy Markdown
Contributor

This reminds me of something I had meant to bring up: I think it's good to start documenting things like this in comments, so that we can use docgen to render nice docs when it's ready. But what do you think of using markdown in comments to structure the documentation?

@garyb

garyb commented Oct 12, 2014

Copy link
Copy Markdown
Member

Sounds perfect to me, I already tend to write comments in that style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants