change structure & add laws for enums#1
Merged
Conversation
Member
|
Thanks, this module has needed some love since the start. It was only thrown in for I guess it will be a little more effort to define an |
garyb
added a commit
that referenced
this pull request
Oct 12, 2014
change structure & add laws for enums
Contributor
|
Looks good, thanks. |
Contributor
|
This reminds me of something I had meant to bring up: I think it's good to start documenting things like this in comments, so that we can use docgen to render nice docs when it's ready. But what do you think of using markdown in comments to structure the documentation? |
Member
|
Sounds perfect to me, I already tend to write comments in that style. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review by @garyb.