Skip to content

parsing v7.0.0, formatters v6.0.0, graphql-client v7.0.0#1008

Merged
thomashoneyman merged 1 commit into
purescript:masterfrom
jamesdbrock:master
Oct 30, 2021
Merged

parsing v7.0.0, formatters v6.0.0, graphql-client v7.0.0#1008
thomashoneyman merged 1 commit into
purescript:masterfrom
jamesdbrock:master

Conversation

@jamesdbrock

@jamesdbrock jamesdbrock commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

parsing v7.0.0, formatters v6.0.0, graphql-client v7.0.0

Disable

  • markfarrell/parsing-hexidecimal
  • markfarrell/parsing-uuid

@jamesdbrock

Copy link
Copy Markdown
Contributor Author

@jamesdbrock

Copy link
Copy Markdown
Contributor Author

Should I comment out formatters from the package-set and then we add formatters back in when it upgrades?

@thomashoneyman

Copy link
Copy Markdown
Member

Yes, we typically decide whether to delay upgrading the root package to avoid breaking things downstream or whether to drop things downstream until they can be updated. In this case would you mind if we get the formatters PR merged and then update both in package sets at once?

@jamesdbrock

Copy link
Copy Markdown
Contributor Author

get the formatters PR merged and then update both in package sets at once?

Sounds good.

@thomashoneyman

Copy link
Copy Markdown
Member

@jamesdbrock jamesdbrock changed the title parsing v7.0.0 parsing v7.0.0, formatters v6.0.0 Oct 26, 2021
@thomashoneyman

Copy link
Copy Markdown
Member

Looks like this is at least affecting graphql-client as well:
https://github.com/OxfordAbstracts/purescript-graphql-client

Error found:
in module Data.GraphQL.Parser
at .spago/graphql-client/v4.0.18/src/Data/GraphQL/Parser.purs:21:36 - 21:52 (line 21, column 36 - line 21, column 52)

  Cannot import type class StringLike from module Text.Parsing.Parser.String
  It either does not exist or the module does not export it.


See https://github.com/purescript/documentation/blob/master/errors/UnknownImport.md for more information,
or to contribute content related to this error.

@jamesdbrock

Copy link
Copy Markdown
Contributor Author

Looks like this is at least affecting graphql-client as well: https://github.com/OxfordAbstracts/purescript-graphql-client

Yeah, what do you think I should do here @thomashoneyman ?

  1. Comment out graphql-client from the package sets in this PR?
  2. Upgrade graphql-client first and then add it to this PR?

New issue: OxfordAbstracts/purescript-graphql-client#65

@thomashoneyman

Copy link
Copy Markdown
Member

@jamesdbrock What do you think of leaving that issue open for a week, and if there's no response in that time we can comment out the library and release a new package set, adding graphql-client back in when it's ready?

For now we could go ahead and comment it out in case there are other failures down the line.

@roryc89

roryc89 commented Oct 27, 2021

Copy link
Copy Markdown
Contributor

Thanks for the heads up. I'll remove StringLike today

@roryc89

roryc89 commented Oct 27, 2021

Copy link
Copy Markdown
Contributor

@jamesdbrock jamesdbrock changed the title parsing v7.0.0, formatters v6.0.0 parsing v7.0.0, formatters v6.0.0, graphql-client v7.0.1 Oct 30, 2021
@thomashoneyman

Copy link
Copy Markdown
Member

@jamesdbrock I think it should be graphql-client v7.0.0

@jamesdbrock jamesdbrock force-pushed the master branch 2 times, most recently from 0b00440 to 32dbad3 Compare October 30, 2021 14:52
@jamesdbrock jamesdbrock changed the title parsing v7.0.0, formatters v6.0.0, graphql-client v7.0.1 parsing v7.0.0, formatters v6.0.0, graphql-client v7.0.0 Oct 30, 2021
Disable
* markfarrell/parsing-hexidecimal
* markfarrell/parsing-uuid
@jamesdbrock

Copy link
Copy Markdown
Contributor Author

Ok I think this is ready to go now. I'll open issues with @markfarrell when it's merged so he can upgrade his packages.

@thomashoneyman thomashoneyman merged commit 94cf732 into purescript:master Oct 30, 2021
@thomashoneyman

Copy link
Copy Markdown
Member

I've merged this, and yea we should open issues (or even pull requests if it's simple) against the two disabled libraries. Thanks @jamesdbrock!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants