Safer definition lists implementation - #974
Merged
Merged
Conversation
Collaborator
|
What do you think, @notriddle? |
Collaborator
|
As near as I can tell, this doesn't break anything. 👍 |
notriddle
reviewed
Oct 26, 2024
Comment on lines
-189
to
-190
| } else { | ||
| self.pop(); |
Collaborator
There was a problem hiding this comment.
I have no idea what I was thinking when I wrote this. It doesn't make sense, and it doesn't seem necessary for anything.
Contributor
Author
There was a problem hiding this comment.
I though the same finding the bug. Looks to me like some sort of premature optimization.
Collaborator
|
OK, thanks, then this can be merged after fixing the CI build! |
Collaborator
|
@mondeja I think you can just rebase this branch and the CI problem will go away. A fix for it has already been merged into the master branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #973