Make fuzz dir part of the workspace - #948
Merged
Merged
Conversation
Collaborator
|
As for mozjs, it’s fine. notriddle/mozjs@f762a70 was a backport. It’s in the official release, now. |
This has the benefit of sharing the build cache and better editor support. Previously it was not possible to do it in `cargo-fuzz` but became possible after rust-fuzz/cargo-fuzz#357.
kdarkhan
force-pushed
the
fuzzer-workspace
branch
from
September 5, 2024 15:38
fa68f69 to
e279dc2
Compare
Collaborator
|
So everything is fine to merge this? |
ollpu
approved these changes
Sep 5, 2024
notriddle
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces 2 changes:
Make
fuzzdir part of the workspacePreviously this was not possible in
cargo-fuzzbut became possible after rust-fuzz/cargo-fuzz#357. It has the benefit of sharing build cache with the other crates and better editor support.Switch to upstream
mozjsNot sure why the fork was used by @notriddle in #842. I did run each fuzzer with upstream dep for a minute without triggering any issues. Please let me know if this change should not be done.