Skip to content

Fix panic when symbols are present in wikilink before pipe - #1004

Merged
Martin1887 merged 1 commit into
pulldown-cmark:masterfrom
frostu8:fix-wikilink-panic-with-symbols
Jan 11, 2025
Merged

Martin1887 merged 1 commit into
pulldown-cmark:masterfrom
frostu8:fix-wikilink-panic-with-symbols

Conversation

@frostu8

@frostu8 frostu8 commented Jan 11, 2025

Copy link
Copy Markdown
Contributor

This probably shouldn't panic:

[frostu8@SHAFT pulldown-cmark]$ echo "[[Wiki<|Link]]" | cargo run -- -W
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.22s
     Running `/home/frostu8/pulldown-cmark/target/debug/pulldown-cmark -W`
thread 'main' panicked at pulldown-cmark/src/parse.rs:2270:57:
begin <= end (8 <= 7) when slicing `[[Wiki<|Link]]
`
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
<p><a href="Wiki%3C">

This PR fixes this bug, adds a regression test and refactors the problematic code for readability. I knew this smelled and I wanted to get this out before a version bump.

@Martin1887
Martin1887 merged commit 25f2806 into pulldown-cmark:master Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants