Merged
Conversation
using keys as values is es6+. this broke [`pull-stream-docs`](https://github.com/pull-stream/pull-stream-docs)'s build because it uglifies the javascript and uglify breaks on anything beyond es5.
Contributor
|
Whoops. Yeah, it slipped my mind. I generally like writing them as ES5 too. Features like shorthand props are just too handy so I forgot! Besides that, I agree: no need to clutter up this package with a build system. |
Member
|
pull-streams are small and light, lets just keep the code as es5. |
Member
|
merged into 2.1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using keys as values is es6+. this broke
pull-stream-docs's build because it uglifies the javascript and uglify breaks on anything beyond es5.note: i'm totally in favor of a subset of es6+, but i think it's best we keep browser compatibility via es5 or specifying browserify transforms in
package.json. or at least that's my strategy. another strategy is to pre-transpile before publish (the most popular yet in my opinion most ugly) or expect consumers to transpile with global transforms.