Repository navigation
feat: GitHub board + drawer adopt DS plugin-kit primitives (pl-tabs, pl-badge, pl-prose, pl-dot, pl-link, pl-iconbtn) and real status tokens (github-plugin#66) - #67
Conversation
…pl-badge, pl-prose, pl-dot, pl-link, pl-iconbtn) and real status tokens (github-plugin#66)
![protoreview[bot]](https://avatars.githubusercontent.com/in/4233969?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA panel review — WARN
code-review-structural · head 47f0df06e783 · formal
Low-risk design-system migration. The panel raised one minor cross-file finding: NEW_ISSUE_PAGE splices the raw _SETUP_CSS (still containing #d29922) while PAGE gets a token-replaced copy, so the two surfaces the docstring says "can't drift" now render the setup card's warning color differently. The verifier confirmed it against the file at head. No panel disagreement; no findings were refuted or dropped. No coverage gaps.
Findings
| Severity | Location | Finding | Verified | |
|---|---|---|---|---|
| 🟡 | minor | view.py:909 |
NEW_ISSUE_PAGE splices the raw _SETUP_CSS (still containing hardcoded #d29922) while PAGE splices a token-replaced copy, so the shared setup card renders with … | confirmed |
findings JSON (machine-readable)
[
{
"file": "view.py",
"line": 909,
"severity": "minor",
"category": "cross-file",
"claim": "NEW_ISSUE_PAGE splices the raw _SETUP_CSS (still containing hardcoded #d29922) while PAGE splices a token-replaced copy, so the shared setup card renders with a hardcoded warning color on /new-issue but a themed token on /view \u2014 diverging the two surfaces the module docstring says 'can't drift' (flagged by both cross-file and conventions review).",
"evidence": "PAGE = PAGE.replace(\"__SETUP_CSS__\", _SETUP_CSS.replace(\"#d29922\", \"var(--pl-color-status-warning)\")).replace(\n \"__SETUP_JS__\", _SETUP_JS\n)\nNEW_ISSUE_PAGE = NEW_ISSUE_PAGE.replace(\"__SETUP_CSS__\", _SETUP_CSS).replace(\"__SETUP_JS__\", _SETUP_JS)",
"verdict": "confirmed",
"note": "view.py:37 has `#setup .warn{color:#d29922}` in _SETUP_CSS; line 910 replaces it for PAGE only, line 912 splices raw _SETUP_CSS into NEW_ISSUE_PAGE. Docstring line 28 says 'so the two surfaces can't drift'. New test asserts #d29922 not in PAGE but never checks NEW_ISSUE_PAGE.",
"line_original": 911,
"line_corrected": true
}
]
There was a problem hiding this comment.
Promoting the WARN verdict for head 47f0df06e783: all checks terminal-green, zero unresolved review threads. (approve-on-green)
Open findings carried by this approval — non-blocking, but they did not go away:
- minor
view.py:909— NEW_ISSUE_PAGE splices the raw _SETUP_CSS (still containing hardcoded #d29922) while PAGE splices a token-replaced copy, so the shared setup card renders with a hardcoded warning color on /new-issue b
Approving a WARN does not resolve its findings (issue #22).
Summary
Migrated board and drawer components to plugin-kit primitives and status tokens, preserving navigation, polling, escaping, and Markdown sanitization. Added component and status assertions and updated the existing Node-driven interaction tests.
Validation passed using the repository’s prebuilt venv: Ruff lint, formatting, and all 535 tests.
Fixes #66