Skip to content

feat: github_review_threads strips CodeRabbit boilerplate before the cap; body_max_chars param (github-plugin#63) - #65

Merged
mabry1985 merged 1 commit into
mainfrom
feat/bd-srb5a-github-review-threads-strips-coderabbit
Nov 7, 2026
Merged

mabry1985 merged 1 commit into
mainfrom
feat/bd-srb5a-github-review-threads-strips-coderabbit

Conversation

@mabry1985

Copy link
Copy Markdown
Member

Summary

github_review_threads truncated each thread's first comment at a fixed 1000 chars on the raw markdown, so CodeRabbit findings — which open with <!-- … --> markers and a long collapsible <details>…</details> analysis chain before the actual finding — were always cut off before the useful text.

This change adds a _strip_review_boilerplate helper that drops HTML comments and <details>…</details> blocks and collapses whitespace before capping, falling back to the first <summary> line only when stripping leaves nothing (so a boilerplate-only thread still shows its headline). The tool gains a body_max_chars: int = 1000 parameter (clamped 200..8000); the overall response remains bounded by _bounded(…, _MAX_PR_CHARS), and the one-line docstring is updated. Plain-body behavior is unchanged. The change is additive — no existing behavior was removed.

Fixes #63

…cap; body_max_chars param (github-plugin#63)

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA panel review — PASS

code-review-structural · head aa95a02c2f1f · formal

No findings were raised, so there was nothing to verify. The panel found no defects across all angles; the verifier confirmed nothing-to-verify. No coverage gaps, no disagreements, no prior items to disposition.

No findings — the review came back clean.

findings JSON (machine-readable)
[]

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promoting the PASS verdict for head aa95a02c2f1f: all checks terminal-green, zero unresolved review threads. (approve-on-green)

@mabry1985
mabry1985 merged commit 8b7e84f into main Nov 7, 2026
4 checks passed
@mabry1985
mabry1985 deleted the feat/bd-srb5a-github-review-threads-strips-coderabbit branch November 7, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

github_review_threads caps each thread body at 1000 chars of mostly CodeRabbit boilerplate, and no tool reads one thread in full

1 participant