Skip to content

feat: github_run_failure keeps context lines before each matched error, plus an optional grep (github-plugin#62) - #64

Merged
mabry1985 merged 1 commit into
mainfrom
feat/bd-iuae2-github-run-failure-keeps-context-lines-b
Nov 7, 2026
Merged

mabry1985 merged 1 commit into
mainfrom
feat/bd-iuae2-github-run-failure-keeps-context-lines-b

Conversation

@mabry1985

Copy link
Copy Markdown
Member

Summary

github_run_failure now retains preceding context (default 5, clamped 0–20), deduplicates lines in log order, and keeps the latest lines within the existing budget. Optional case-insensitive regex grep replaces the default filter and returns readable errors for invalid patterns.

Added regression coverage and updated the existing error-only test to use context=0. Ruff lint and formatting checks pass; all 524 tests pass.

Fixes #62

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA panel review — PASS

code-review · head 7a669d36cf45 · formal

Clean PR — all four finder lanes (correctness, removed-behavior, cross-file, conventions) independently examined the diff and reported no defects. The verifier confirmed there was nothing to verify. No panel disagreement, no coverage gaps, no fix-first item. Nothing to address before merge.

No findings — the review came back clean.

findings JSON (machine-readable)
[]

@protoreview protoreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promoting the PASS verdict for head 7a669d36cf45: all checks terminal-green, zero unresolved review threads. (approve-on-green)

@mabry1985
mabry1985 merged commit bf050ae into main Nov 7, 2026
4 checks passed
@mabry1985
mabry1985 deleted the feat/bd-iuae2-github-run-failure-keeps-context-lines-b branch November 7, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

github_run_failure shows only retry-wrapper lines and filters out the failing sub-check's own output

1 participant