Repository navigation
feat: github_run_failure keeps context lines before each matched error, plus an optional grep (github-plugin#62) - #64
Merged
mabry1985 merged 1 commit intoNov 7, 2026
Conversation
…r, plus an optional grep (github-plugin#62)
There was a problem hiding this comment.
QA panel review — PASS
code-review · head 7a669d36cf45 · formal
Clean PR — all four finder lanes (correctness, removed-behavior, cross-file, conventions) independently examined the diff and reported no defects. The verifier confirmed there was nothing to verify. No panel disagreement, no coverage gaps, no fix-first item. Nothing to address before merge.
No findings — the review came back clean.
findings JSON (machine-readable)
[]
mabry1985
deleted the
feat/bd-iuae2-github-run-failure-keeps-context-lines-b
branch
November 7, 2026 02:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github_run_failurenow retains preceding context (default 5, clamped 0–20), deduplicates lines in log order, and keeps the latest lines within the existing budget. Optional case-insensitive regexgrepreplaces the default filter and returns readable errors for invalid patterns.Added regression coverage and updated the existing error-only test to use
context=0. Ruff lint and formatting checks pass; all 524 tests pass.Fixes #62