fix: replace bare except with except BaseException in decorator#1160
Open
harshadkhetpal wants to merge 1 commit intoprometheus:masterfrom
Open
fix: replace bare except with except BaseException in decorator#1160harshadkhetpal wants to merge 1 commit intoprometheus:masterfrom
harshadkhetpal wants to merge 1 commit intoprometheus:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace bare
except:withexcept BaseException:inprometheus_client/decorator.py(PEP 8 E722).The bare
exceptclause catches everything includingSystemExitandKeyboardInterrupt. Since this block re-raises the exception, usingexcept BaseException:preserves the exact same behavior while being explicit about the intent.Change:
Testing
No behavior change — the
raisere-raises the caught exception regardless.BaseExceptioncatches everything just like bareexcept, but satisfies PEP 8 E722.