feat: Add readTimeout and conenctionTimeout as configurable parameters#1658
Merged
Conversation
zeitlinger
reviewed
Nov 3, 2025
zeitlinger
left a comment
zeitlinger
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
| <version>${project.version}</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> |
Member
There was a problem hiding this comment.
why a new dependency? have a look at
Member
|
A pushed a change that reads the properties from a file to be in line with the other properties |
Member
|
@hmhuan please fix the build - and let me know if you want to have this PR included in the upcoming release |
Contributor
Author
|
Hi @zeitlinger , Thank you for your support. I will fix the build and update on this weekend. |
Contributor
Author
Hey @zeitlinger, I have just remove the test dependency and remove redundant test. Please help me to review and include this PR in the upcoming release. Thank you very much |
zeitlinger
reviewed
Nov 6, 2025
Signed-off-by: huan.huynh <[email protected]>
Signed-off-by: Gregor Zeitlinger <[email protected]> Signed-off-by: huan.huynh <[email protected]>
Signed-off-by: huan.huynh <[email protected]>
zeitlinger
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got the issue like below so I would like to contribute to fix it by apply configurable for
connectionTimeoutandreadTimeout.