Skip to content

Update instructions for Windows GCM - #1724

Closed
mavaddat wants to merge 1 commit into
progit:mainfrom
mavaddat:patch-1
Closed

Update instructions for Windows GCM#1724
mavaddat wants to merge 1 commit into
progit:mainfrom
mavaddat:patch-1

Conversation

@mavaddat

Copy link
Copy Markdown
Contributor

Changes

Microsoft/Git-Credential-Manager-for-Windows was archived on 2020 Sep 30 and it is no longer being maintained.

The cross-platform Git Credential Manager Core (GCM Core) is the official replacement.

Therefore, I have updated the documentation to reflect this fact and recommend instead that readers rely on Git Credential Manager Core (GCM Core).

Context

#736
#583

[Microsoft/Git-Credential-Manager-for-Windows](https://github.com/Microsoft/Git-Credential-Manager-for-Windows) was archived on 2020 Sep 30 and it is no longer being maintained. 

> The cross-platform [Git Credential Manager Core (GCM Core)](https://aka.ms/gcmcore) is the official replacement.
@HonkingGoose

Copy link
Copy Markdown
Contributor

There's a GitHub Blog about the Git Credential Manager that explains all the changes. 😉

We may need to check the whole credentials.asc file, and update it? But that should be tracked in its own issue probably. 😄

@mavaddat

mavaddat commented Apr 8, 2022

Copy link
Copy Markdown
Contributor Author

There's a GitHub Blog about the Git Credential Manager that explains all the changes.

Yes! That blog post is a nice historiographic explanation of the GCM module. It contains much more than the specific technical details needed to get using GCM. I distilled the info from my own findings using trial-and-error to successfully implement GCM in both Linux (WSL2) and Windows.

We may need to check the whole credentials.asc file, and update it? But that should be tracked in its own issue probably.

When I originally submitted the PR, I reviewed the chapter and it seemed up-to-date except this part. But I will take another look.

@HonkingGoose

Copy link
Copy Markdown
Contributor

When I originally submitted the PR, I reviewed the chapter and it seemed up-to-date except this part. But I will take another look.

Thank you for checking it over! Let us know what you find!

@ben ben left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Just one nit, and it looks like #1789 introduced a merge conflict, and we can merge it. Thanks!

This is similar to the "`osxkeychain`" helper described above, but uses the Windows Credential Store to control sensitive information.
It can be found at https://github.com/Microsoft/Git-Credential-Manager-for-Windows[].
* If you're using Windows, you can enable the *Git Credential Manager* feature when installing https://gitforwindows.org/[Git for Windows] or separately install https://github.com/GitCredentialManager/git-credential-manager/releases/latest[the latest GCM] as a standalone service.
This is similar to the "`osxkeychain`" helper described above, but uses the Windows Credential Store to control sensitive information. It can also serve credentials to WSL1 or WSL2. See https://github.com/GitCredentialManager/git-credential-manager#windows[GCM Install Instructions] for more information.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind splitting this into two lines? Diffs are much easier to parse if it's one sentence per line.

@mavaddat

Copy link
Copy Markdown
Contributor Author

I have continued this PR in #1794

@mavaddat mavaddat closed this Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants