Skip to content

Modernize recommendation for credential store - #1708

Merged
ben merged 3 commits into
progit:mainfrom
vtbassmatt:patch-1
Jan 28, 2022
Merged

Modernize recommendation for credential store#1708
ben merged 3 commits into
progit:mainfrom
vtbassmatt:patch-1

Conversation

@vtbassmatt

Copy link
Copy Markdown
Contributor

GCM for Windows (along with GCM for macOS/Linux) has been replaced with the cross-platform GCM Core.

Changes

Remove mention of "GCM for Windows", replace with "GCM Core".

Context

GCM for Windows has been superseded GCM Core. GCM for Windows is deprecated and no longer supported.

GCM for Windows (along with GCM for macOS/Linux) has been replaced with the cross-platform GCM Core.

@dscho dscho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this pretty stale part of the book!

Comment thread book/07-git-tools/sections/credentials.asc Outdated
Comment thread book/07-git-tools/sections/credentials.asc Outdated
@dscho

dscho commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

Oh, I see... #1724 already does what I suggested...

@vtbassmatt

Copy link
Copy Markdown
Contributor Author

@ben or @schacon, would you consider this small improvement?

@dscho

dscho commented Jan 28, 2022

Copy link
Copy Markdown
Contributor

** dscho ** approved these changes 35 seconds ago

In case it was unclear: I am not some random drive-by reviewer, I reviewed this in my role as the maintainer of Git for Windows.

Comment thread book/07-git-tools/sections/credentials.asc Outdated
@HonkingGoose HonkingGoose mentioned this pull request Jan 28, 2022
5 tasks
@ben

ben commented Jan 28, 2022

Copy link
Copy Markdown
Member

I like it. Thanks!

@ben
ben merged commit e99355e into progit:main Jan 28, 2022
@vtbassmatt
vtbassmatt deleted the patch-1 branch January 28, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants